Date: Sun, 20 May 2018 15:18:15 -0700 From: Eitan Adler <eadler@freebsd.org> To: Kirill Ponomarev <kp@krion.cc> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r333919 - in head/contrib/file: . doc magic magic/Magdir python src tests Message-ID: <CAF6rxgm73%2B4D1=CofwQX36rmzdYMgqLaPXzo9aDLoG9HjaCBUQ@mail.gmail.com> In-Reply-To: <20180520212726.GA42447@krion.cc> References: <201805200506.w4K56gps088300@repo.freebsd.org> <CAALwa8kU61eUhmxdirf8qdatwWfmRVRLax75J27JPPmxepdh3g@mail.gmail.com> <CAALwa8mp3_u8Lp=hLy9tR98Y0JWVLzSQ-_QeLa4vpNOkhCue4A@mail.gmail.com> <20180520212726.GA42447@krion.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On 20 May 2018 at 14:27, Kirill Ponomarev <kp@krion.cc> wrote: > On 05/20, Antoine Brodin wrote: >> On Sun, May 20, 2018 at 10:30 PM, Antoine Brodin <antoine@freebsd.org> wrote: >> > On Sun, May 20, 2018 at 7:06 AM, Eitan Adler <eadler@freebsd.org> wrote: >> >> Author: eadler >> >> Date: Sun May 20 05:06:42 2018 >> >> New Revision: 333919 >> >> URL: https://svnweb.freebsd.org/changeset/base/333919 >> >> >> >> Log: >> >> MFV: file 5.33 >> >> >> >> Merge the latest file(1) in. >> >> >> >> Relevent Changelog: >> >> - extend the support for ${x?:} expansions for magic descriptions >> >> - add support for ${x?:} in mime types to handle pie binaries. >> >> - add support for negative offsets (offsets from the end of file) >> >> - close the file on error when writing magic >> >> >> >> Relnotes: yes >> > >> > Hi, >> > >> > This breaks the ports tree, please revert and request an exp-run. >> >> At least revert the changes to contrib/file/magic/Magdir/elf > > Eitan, please coordinate your efforts with portmgr first (for > exp-run) before committing such changes. I had no reason to believe this would break ports. Now that is has, my world view has changed, and I'll ask for an exp-run before even minor changes to libmagic. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgm73%2B4D1=CofwQX36rmzdYMgqLaPXzo9aDLoG9HjaCBUQ>