Date: Fri, 28 Jul 2023 16:40:11 +0200 From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= <fernape@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: "ports-committers@FreeBSD.org" <ports-committers@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 79e5fba255ef - main - cad/PrusaSlicer: update to 2.6.0 Message-ID: <CAGwOe2YcXfogxwCODdHvOLPZExeXC_BN4knB3obFb_7EQUuA-g@mail.gmail.com> In-Reply-To: <ZMO8UT68PlITqFuB@FreeBSD.org> References: <202307281248.36SCmERV027986@gitrepo.freebsd.org> <ZMO8UT68PlITqFuB@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] El vie, 28 jul 2023, 15:02, Alexey Dokuchaev <danfe@freebsd.org> escribió: > On Fri, Jul 28, 2023 at 12:48:14PM +0000, Fernando Apestegu??a wrote: > > commit 79e5fba255ef2620dd872e21bdd7dc667fea3c19 > > > > cad/PrusaSlicer: update to 2.6.0 > > > > PR: 272730 > > Reported by: michal.zielonka.8001@gmail.com > > Approved by: teodorsigaev@gmail.com (maintainer) > > --- > > cad/PrusaSlicer/Makefile | 14 +- > > cad/PrusaSlicer/distinfo | 6 +- > > cad/PrusaSlicer/files/patch-CMakeLists.txt | 19 +- > > cad/PrusaSlicer/files/patch-src_CMakeLists.txt | 15 +- > > cad/PrusaSlicer/files/patch-src_avrdude_arduino.c | 10 + > > .../files/patch-src_libnanosvg_nanosvg.h | 3109 > ++++++++++++++++++++ > > .../files/patch-src_libnanosvg_nanosvgrast.h | 1485 ++++++++++ > > Who reviewed this? First, we don't create files via patches, and > Maintainer did. It's in the commit log and in the PR. second, why not properly depend on `graphics/nanosvg' port? > > > diff --git a/cad/PrusaSlicer/files/patch-src_libnanosvg_nanosvg.h > b/cad/PrusaSlicer/files/patch-src_libnanosvg_nanosvg.h > > new file mode 100644 > > index 000000000000..08bf0beb1ef1 > > --- /dev/null > > +++ b/cad/PrusaSlicer/files/patch-src_libnanosvg_nanosvg.h > > @@ -0,0 +1,3109 @@ > > +--- src/libnanosvg/nanosvg.h.orig 1970-01-01 01:00:00.000000000 +0100 > > ++++ src/libnanosvg/nanosvg.h 2022-12-22 00:42:08.000000000 +0100 > > +@@ -0,0 +1,3106 @@ > > ++/* > > ++ * Copyright (c) 2013-14 Mikko Mononen memon@inside.org > > ... > > ./danfe > [-- Attachment #2 --] <div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">El vie, 28 jul 2023, 15:02, Alexey Dokuchaev <<a href="mailto:danfe@freebsd.org">danfe@freebsd.org</a>> escribió:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Fri, Jul 28, 2023 at 12:48:14PM +0000, Fernando Apestegu??a wrote:<br> > commit 79e5fba255ef2620dd872e21bdd7dc667fea3c19<br> > <br> > cad/PrusaSlicer: update to 2.6.0<br> > <br> > PR: 272730<br> > Reported by: <a href="mailto:michal.zielonka.8001@gmail.com" target="_blank" rel="noreferrer">michal.zielonka.8001@gmail.com</a><br> > Approved by: <a href="mailto:teodorsigaev@gmail.com" target="_blank" rel="noreferrer">teodorsigaev@gmail.com</a> (maintainer)<br> > ---<br> > cad/PrusaSlicer/Makefile | 14 +-<br> > cad/PrusaSlicer/distinfo | 6 +-<br> > cad/PrusaSlicer/files/patch-CMakeLists.txt | 19 +-<br> > cad/PrusaSlicer/files/patch-src_CMakeLists.txt | 15 +-<br> > cad/PrusaSlicer/files/patch-src_avrdude_arduino.c | 10 +<br> > .../files/patch-src_libnanosvg_nanosvg.h | 3109 ++++++++++++++++++++<br> > .../files/patch-src_libnanosvg_nanosvgrast.h | 1485 ++++++++++<br> <br> Who reviewed this? First, we don't create files via patches, and<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Maintainer did. It's in the commit log and in the PR.</div><div dir="auto"><br></div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> second, why not properly depend on `graphics/nanosvg' port?<br> <br> > diff --git a/cad/PrusaSlicer/files/patch-src_libnanosvg_nanosvg.h b/cad/PrusaSlicer/files/patch-src_libnanosvg_nanosvg.h<br> > new file mode 100644<br> > index 000000000000..08bf0beb1ef1<br> > --- /dev/null<br> > +++ b/cad/PrusaSlicer/files/patch-src_libnanosvg_nanosvg.h<br> > @@ -0,0 +1,3109 @@<br> > +--- src/libnanosvg/nanosvg.h.orig 1970-01-01 01:00:00.000000000 +0100<br> > ++++ src/libnanosvg/nanosvg.h 2022-12-22 00:42:08.000000000 +0100<br> > +@@ -0,0 +1,3106 @@<br> > ++/*<br> > ++ * Copyright (c) 2013-14 Mikko Mononen <a href="mailto:memon@inside.org" target="_blank" rel="noreferrer">memon@inside.org</a><br> > ...<br> <br> ./danfe<br> </blockquote></div></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGwOe2YcXfogxwCODdHvOLPZExeXC_BN4knB3obFb_7EQUuA-g>