Date: Mon, 1 Jun 2020 16:27:16 +0000 From: "neel_neelc.org (Neel Chauhan)" <phabric-noreply@FreeBSD.org> To: Phabricator <phabric-noreply@FreeBSD.org> Cc: freebsd-net@freebsd.org Subject: [Differential] D24989: netinet: Generate a random RSS key on boot. Message-ID: <85bee9ae355b182cee0e743d5423e658@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-yukac7sf5rncf2mc6vjo-req@reviews.freebsd.org> References: <differential-rev-PHID-DREV-yukac7sf5rncf2mc6vjo-req@reviews.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
neel_neelc.org added a comment. I believe Linux just uses random keys: - https://github.com/torvalds/linux/blob/29d9f30d4ce6c7a38745a54a8cddface10013490/net/ethtool/ioctl.c#L924 Callers (example): - https://github.com/torvalds/linux/blob/29d9f30d4ce6c7a38745a54a8cddface10013490/drivers/net/ethernet/emulex/benet/be_main.c#L3728 - https://github.com/torvalds/linux/blob/29d9f30d4ce6c7a38745a54a8cddface10013490/drivers/net/ethernet/emulex/benet/be_main.c#L3728 However, DPDK uses something called "MAXIMALLY EQUIDISTRIBUTEDCOMBINED LFSR GENERATORS" (paper: https://www.ams.org/journals/mcom/1999-68-225/S0025-5718-99-01039-X/S0025-5718-99-01039-X.pdf): - https://github.com/DPDK/dpdk/blob/905a0c208267806f5e1f2021accec4302681e4a0/lib/librte_eal/common/rte_random.c#L131 - Calls https://github.com/DPDK/dpdk/blob/905a0c208267806f5e1f2021accec4302681e4a0/lib/librte_eal/common/rte_random.c#L101 Caller (example): - https://github.com/DPDK/dpdk/blob/c3d30e9d753ef3121c25b9403bf56ee09f2a2086/drivers/net/bnx2x/bnx2x.c#L6701 REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D24989/new/ REVISION DETAIL https://reviews.freebsd.org/D24989 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: neel_neelc.org, #csprng, markm Cc: avg, markm, cem, #csprng, kevans, debdrup, rwatson, imp, ae, melifaro, #contributor_reviews_base, freebsd-net-list, mmacy, kpraveen.lkml_gmail.com, marcnarc_gmail.com, simonvella_gmail.com, novice_techie.com, tommi.pernila_iki.fi, krzysztof.galazka_intel.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?85bee9ae355b182cee0e743d5423e658>