Date: Tue, 01 Oct 2024 19:04:42 +0200 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: Pietro Cerutti <gahr@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 2ba4ed91621e - main - sysutils/createrepo_c: new port Message-ID: <7d47230ac2447012cb48fb81b3120d40@mail.infomaniak.com> In-Reply-To: <202410011223.491CNu6S051590@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 2024-10-01T14:23:56.000+02:00, Pietro Cerutti <gahr@FreeBSD.org> wrote: > The branch main has been updated by gahr: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=2ba4ed91621e5f7054224acda61afed58cb380b1 > > commit 2ba4ed91621e5f7054224acda61afed58cb380b1 > > Author: Pietro Cerutti <gahr@FreeBSD.org> > > AuthorDate: 2024-10-01 12:22:30 +0000 > > Commit: Pietro Cerutti <gahr@FreeBSD.org> > > CommitDate: 2024-10-01 12:23:54 +0000 > > sysutils/createrepo_c: new port > > > > createrepo_c is a C implementation of the createrepo tool, which generates > > metadata for RPM package repositories. It is optimized for performance and > > provides new features compared to the original createrepo written in Python. .... Hi, Please review Porters Handbook, there are several "guidelines" to make the tree more consistent and reducing overall workload. PORTVERSION --> DISTVERSION https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github ...and stray(?) comment? Correct maintainer? There's no reference and from what I can tell no submitted PR in Bugzilla. libxml2 dependency should use the GNOME helper https://docs.freebsd.org/en/books/porters-handbook/book/#using-gnome https://docs.freebsd.org/en/books/porters-handbook/book/#gnome-components sqlite3 dependency should also use a helper https://docs.freebsd.org/en/books/porters-handbook/book/#using-databases-uses CMAKE_ARGS can be replaced with CMAKE_OFF= ENABLE_PYTHON https://docs.freebsd.org/en/books/porters-handbook/book/#using-cmake do-test section can be replaced with USES= cmake:testing https://cgit.freebsd.org/ports/tree/Mk/Uses/cmake.mk#n20 You also seem to have submitted changes upstream (great initiative, please add a note about in the commit msg next time), these can probably apply these using this method to clean up the Makefile further. https://cgit.freebsd.org/ports/tree/irc/irssi/Makefile?id=ef1857fc1c757152f595dd87121d260f6e3fb25d#n7 Poudriere also lists quite a few warnings about dependencies and the REINPLACE_CMD commands. It also seems to look for Doxygen by default which you probably want to disable to avoid potential plist issues. https://pdr2.bofh.network/data/141-diizzy/2024-10-01_11h36m29s/logs/createrepo_c-1.1.4.log Best regards, Daniel [-- Attachment #2 --] <html><body><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">On 2024-10-01T14:23:56.000+02:00, Pietro Cerutti <gahr@FreeBSD.org> wrote:<br></div><div ><div><br></div></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div class="ik_mail_quote answerContentMessage"><blockquote class="ws-ng-quote"><pre style="white-space: normal;"><div>The branch main has been updated by gahr:<br></div><div><br></div><div>URL: <a href="https://cgit.FreeBSD.org/ports/commit/?id=2ba4ed91621e5f7054224acda61afed58cb380b1" class="defaultMailLink" rel="noopener noreferrer" data-ik="ik-secure" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=2ba4ed91621e5f7054224acda61afed58cb380b1</a><br></div><div><br></div><div>commit 2ba4ed91621e5f7054224acda61afed58cb380b1<br></div><div>Author: Pietro Cerutti <<a href="mailto:gahr@FreeBSD.org" class="defaultMailLink">gahr@FreeBSD.org</a>><br></div><div>AuthorDate: 2024-10-01 12:22:30 +0000<br></div><div>Commit: Pietro Cerutti <<a href="mailto:gahr@FreeBSD.org" class="defaultMailLink">gahr@FreeBSD.org</a>><br></div><div>CommitDate: 2024-10-01 12:23:54 +0000<br></div><div><br></div><div> sysutils/createrepo_c: new port<br></div><div> <br></div><div> createrepo_c is a C implementation of the createrepo tool, which generates<br></div><div> metadata for RPM package repositories. It is optimized for performance and<br></div><div> provides new features compared to the original createrepo written in Python.<br></div></pre></blockquote></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">....<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Hi,<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Please review Porters Handbook, there are several "guidelines" to make the tree more consistent and reducing overall workload.<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">PORTVERSION --> DISTVERSION<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><a href="https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github</a><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">...and stray(?) comment?<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Correct maintainer? There's no reference and from what I can tell no submitted PR in Bugzilla.<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">libxml2 dependency should use the GNOME helper<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><a href="https://docs.freebsd.org/en/books/porters-handbook/book/#using-gnome" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">https://docs.freebsd.org/en/books/porters-handbook/book/#using-gnome</a><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><a href="https://docs.freebsd.org/en/books/porters-handbook/book/#gnome-components" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">https://docs.freebsd.org/en/books/porters-handbook/book/#gnome-components</a><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">sqlite3 dependency should also use a helper<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><a href="https://docs.freebsd.org/en/books/porters-handbook/book/#using-databases-uses" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">https://docs.freebsd.org/en/books/porters-handbook/book/#using-databases-uses</a><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">CMAKE_ARGS can be replaced with CMAKE_OFF= ENABLE_PYTHON<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><a href="https://docs.freebsd.org/en/books/porters-handbook/book/#using-cmake" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">https://docs.freebsd.org/en/books/porters-handbook/book/#using-cmake</a><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">do-test section can be replaced with USES= cmake:testing<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><a href="https://cgit.freebsd.org/ports/tree/Mk/Uses/cmake.mk#n20" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">https://cgit.freebsd.org/ports/tree/Mk/Uses/cmake.mk#n20</a><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">You also seem to have submitted changes upstream (great initiative, please add a note about in the commit msg next time), these can probably apply these using this method to clean up the Makefile further.<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><a href="https://cgit.freebsd.org/ports/tree/irc/irssi/Makefile?id=ef1857fc1c757152f595dd87121d260f6e3fb25d#n7" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">https://cgit.freebsd.org/ports/tree/irc/irssi/Makefile?id=ef1857fc1c757152f595dd87121d260f6e3fb25d#n7</a><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Poudriere also lists quite a few warnings about dependencies and the REINPLACE_CMD commands. It also seems to look for Doxygen by default which you probably want to disable to avoid potential plist issues.<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><a href="https://pdr2.bofh.network/data/141-diizzy/2024-10-01_11h36m29s/logs/createrepo_c-1.1.4.log" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">https://pdr2.bofh.network/data/141-diizzy/2024-10-01_11h36m29s/logs/createrepo_c-1.1.4.log</a><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Best regards,<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Daniel<br></div></body></html>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7d47230ac2447012cb48fb81b3120d40>