Date: Mon, 4 May 2026 21:59:24 +0100 From: Oliver Pinter <oliver.pntr@gmail.com> To: "Simon J. Gerraty" <sjg@juniper.net> Cc: "Enji Cooper (yaneurabeya)" <yaneurabeya@gmail.com>, =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= <des@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: 566cc005812b - main - safe_set treat ':' and '#' differently Message-ID: <CAPjTQNEVOP2B3=kEysfJtTZDYQwwSutYbzaaOLiE-sMbfMrHMQ@mail.gmail.com> In-Reply-To: <14577.1777919687@kaos.jnpr.net> References: <69e8f964.39869.24418b55@gitrepo.freebsd.org> <86jyts1xzr.fsf@ltc.des.dev> <15177.1777314263@kaos.jnpr.net> <86bjf41chq.fsf@ltc.des.dev> <24831.1777314998@kaos.jnpr.net> <A23772E7-6D51-46E6-BD9C-515D70C16BEA@gmail.com> <6875.1777333471@kaos.jnpr.net> <CAPjTQNFrg8yf3ze5eh%2BAgMmG%2B0fUOjtBHj1yg6NT__StAtMhDA@mail.gmail.com> <6906.1777574491@kaos.jnpr.net> <14577.1777919687@kaos.jnpr.net>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Hi! On Monday, May 4, 2026, Simon J. Gerraty <sjg@juniper.net> wrote: > Simon J. Gerraty <sjg@juniper.net> wrote: > > > Oliver Pinter <oliver.pntr@gmail.com> wrote: > > > Could you please add some unit test for the supported use cases to > > > avoid future confusions? > > > > Sure. safe_eval.sh is setup to support that. > > https://reviews.freebsd.org/D56795 > > Not sure if anything else needs updating. Thanks! I've seen that it tests for ``, but what's about $()? Tests work as expected from src tree. > [-- Attachment #2 --] Hi!<br><br>On Monday, May 4, 2026, Simon J. Gerraty <<a href="mailto:sjg@juniper.net">sjg@juniper.net</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Simon J. Gerraty <<a href="mailto:sjg@juniper.net">sjg@juniper.net</a>> wrote:<br> <br> > Oliver Pinter <<a href="mailto:oliver.pntr@gmail.com">oliver.pntr@gmail.com</a>> wrote:<br> > > Could you please add some unit test for the supported use cases to<br> > > avoid future confusions?<br> > <br> > Sure. safe_eval.sh is setup to support that.<br> <br> <a href="https://reviews.freebsd.org/D56795" target="_blank">https://reviews.freebsd.org/<wbr>D56795</a><br>; <br> Not sure if anything else needs updating.</blockquote><div><br></div><div>Thanks! I've seen that it tests for ``, but what's about $()?<br></div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Tests work as expected from src tree.<br> </blockquote>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPjTQNEVOP2B3=kEysfJtTZDYQwwSutYbzaaOLiE-sMbfMrHMQ>