Date: Sat, 17 Feb 2007 12:07:43 -0500 From: Craig Rodrigues <rodrigc@crodrigues.org> To: Olivier Houchard <mlfbsd@cognet.ci0.org> Cc: Scot Hetzel <swhetzel@gmail.com>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: mount_ntfs: /dev/ad0s1: No such file or directory Message-ID: <20070217170743.GA28585@crodrigues.org> In-Reply-To: <20070217164904.GA31437@ci0.org> References: <790a9fff0702161738r154b5087m877c604092727e39@mail.gmail.com> <20070217021629.GA24579@ci0.org> <20070217162233.GA28315@crodrigues.org> <20070217164904.GA31437@ci0.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Feb 17, 2007 at 05:49:04PM +0100, Olivier Houchard wrote: > Apparently not enough ;-) > I'm in discussion with Bruce Evans about this, he brought up valid concerns > about this change, maybe I'll revert it and check all consumers of vfs_getopts > to make sure they check the return value instead. I'm not opposed to your vfs_mount.c change since it is quite reasonable. It's just that in the mount code in FreeBSD, over the years, a lot of behavior has been built on unreasonable API's, so changing things exposes weird bugs. :) mount_ntfs should probably be converted to properly use nmount() like mount_msdosfs. The nmount() call path in the ntfs file system code should probably be fixed up too. I don't have any NTFS partitions on my FreeBSD system. Does someone have a small NTFS disk image that they can send me so I can implement some of these changes and practise mounting? -- Craig Rodrigues rodrigc@crodrigues.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070217170743.GA28585>