Date: Thu, 13 Dec 2001 15:41:58 +0200 From: Sheldon Hearn <sheldonh@starjuice.net> To: audit@FreeBSD.org Subject: REQ: Please test libmchain dependency patch for smbfs Message-ID: <877.1008250918@axl.seasidesoftware.co.za> In-Reply-To: Your message of "Thu, 13 Dec 2001 05:08:35 PST." <200112131308.fBDD8Zm59173@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi folks, Could someone with a RELENG_4 scratchbox test the patch at the bottom of this message? It merges rev 1.5 of smbfs_vfsops.c onto the RELENG_4 branch: > Modified files: > sys/fs/smbfs smbfs_vfsops.c > Log: > Add module dependency on libmchain. > > With this change, mounting an smb share (using mount_smb, which is not > yet included in the tree) without any of smbfs, libiconv or libmchain > compiled into the kernel or loaded works. How to test: 1) Apply patch. 2) Ensure that NETSMB, SMBFS, LIBICONV and LIBMCHAIN are _not_ included in the kernel config file. 3) Build kernel and modules. This may be very important, because I had horrible panics with just a day-old kernel when I tested this on -CURRENT. 4) Install and boot new kernel. 5) Verify that smbfs, libiconv and libmchain are _not_ wired into the kernel with: kldstat -v | egrep '(smbfs|libiconv|libmchain)' 6) Try to mount an smb share with the mount command. The smbfs, libiconv and libmchain drivers should automatically be loaded and the mount shoudl be successful. 7) Umount the smb share, ignoring the "smbfs_closel: Negative opencount" error. 8) Unload smbfs, and confirm that libiconv and libmchain are automatically unloaded with: kldstat | egrep '(smbfs|libiconv|libmchain)' 9) Repeat steps 6 through 8. If that works, I'd like to MFC the change, since it'll make getting smbfs support in 4.5-RELEASE as easy as installing the net/smbfs port. Ciao, Sheldon. Index: smbfs_vfsops.c =================================================================== RCS file: /home/ncvs/src/sys/fs/smbfs/smbfs_vfsops.c,v retrieving revision 1.2.2.3 diff -u -d -r1.2.2.3 smbfs_vfsops.c --- smbfs_vfsops.c 25 Oct 2001 19:18:52 -0000 1.2.2.3 +++ smbfs_vfsops.c 13 Dec 2001 13:31:05 -0000 @@ -45,6 +45,7 @@ #include <sys/mount.h> #include <sys/stat.h> #include <sys/malloc.h> +#include <sys/module.h> #include <netsmb/smb.h> @@ -124,6 +125,7 @@ MODULE_DEPEND(smbfs, netsmb, NSMB_VERSION, NSMB_VERSION, NSMB_VERSION); MODULE_DEPEND(smbfs, libiconv, 1, 1, 1); +MODULE_DEPEND(smbfs, libmchain, 1, 1, 1); int smbfs_pbuf_freecnt = -1; /* start out unlimited */ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?877.1008250918>