Date: Sat, 13 Jul 2024 06:11:04 +0200 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: Mathieu Arnold <mat@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org, Baptiste Daroussin <bapt@freebsd.org> Subject: Re: git: 06601897e5cd - main - framework: reintroduce the feature enabling code Message-ID: <12af8e210220224883a7856115f61be9@mail.infomaniak.com> In-Reply-To: <202404120754.43C7slbr026326@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 2024-04-12T09:54:47.000+02:00, Mathieu Arnold <mat@FreeBSD.org> wrote: > The branch main has been updated by mat: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=06601897e5cd4afcc31f3b508b2cbb2bc7d4a677 > > commit 06601897e5cd4afcc31f3b508b2cbb2bc7d4a677 > > Author: Mathieu Arnold <mat@FreeBSD.org> > > AuthorDate: 2024-04-12 07:49:01 +0000 > > Commit: Mathieu Arnold <mat@FreeBSD.org> > > CommitDate: 2024-04-12 07:53:27 +0000 > > framework: reintroduce the feature enabling code > > > > For each feature (see in Mk/Features) users can now set these variables > > in their make.conf. Using LTO as an example. > > > > To enable globally: > > > > WITH_LTO= yes > > > > To disable globally (for example ssp is enabled by default): > > > > WITHOUT_LTO= yes > > > > To enable for a specific list of ports: > > > > WITH_LTO_PORTS= lang/perl5.36 > > > > To disable for a specific list of ports: > > > > WITHOUT_LTO_PORTS= lang/perl5.36 > > > > Differential Revision: https://reviews.freebsd.org/D44750 > > --- > > Mk/Uses/cargo.mk [http://cargo.mk] | 4 +--- > > Mk/bsd.port.mk [http://bsd.port.mk] | 42 ++++++++++++++++++++++++++++++++++-------- > > net-mgmt/net-snmp/Makefile | 2 +- > > 3 files changed, 36 insertions(+), 12 deletions(-) > > diff --git a/Mk/Uses/cargo.mk [http://cargo.mk] b/Mk/Uses/cargo.mk [http://cargo.mk] > > index e3b733d35821..8710374e3584 100644 > > --- a/Mk/Uses/cargo.mk [http://cargo.mk] > > +++ b/Mk/Uses/cargo.mk [http://cargo.mk] > > @@ -139,10 +139,8 @@ CARGO_ENV+= \ > > CARGO_ENV+= RUST_BACKTRACE=1 > > . endif > > > > -. if !defined(_WITHOUT_LTO) && (!defined(WITHOUT_LTO_PORTS) || ${WITHOUT_LTO_PORTS:N${PKGORIGIN}}) > > +. if defined(WITH_LTO) > > _CARGO_MSG= "===> Additional optimization to port applied" > > -_WITH_LTO= yes > > -.undef _WITHOUT_LTO > > . endif Hi, This changes so LTO option is no longer applied to Rust (cargo) ports BY DEFAULT causing a regresssion, please fix. Best regards, Daniel [-- Attachment #2 --] <html><body><div>On 2024-04-12T09:54:47.000+02:00, Mathieu Arnold <mat@FreeBSD.org> wrote:<br></div><div ><div><br></div></div><div class="ik_mail_quote answerContentMessage"><blockquote class="ws-ng-quote"><pre style="white-space: normal;"><div>The branch main has been updated by mat:<br></div><div><br></div><div>URL: <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://cgit.FreeBSD.org/ports/commit/?id=06601897e5cd4afcc31f3b508b2cbb2bc7d4a677" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=06601897e5cd4afcc31f3b508b2cbb2bc7d4a677</a><br></div><div><br></div><div>commit 06601897e5cd4afcc31f3b508b2cbb2bc7d4a677<br></div><div>Author: Mathieu Arnold <<a class="defaultMailLink" href="mailto:mat@FreeBSD.org">mat@FreeBSD.org</a>><br></div><div>AuthorDate: 2024-04-12 07:49:01 +0000<br></div><div>Commit: Mathieu Arnold <<a class="defaultMailLink" href="mailto:mat@FreeBSD.org">mat@FreeBSD.org</a>><br></div><div>CommitDate: 2024-04-12 07:53:27 +0000<br></div><div><br></div><div> framework: reintroduce the feature enabling code<br></div><div> <br></div><div> For each feature (see in Mk/Features) users can now set these variables<br></div><div> in their make.conf. Using LTO as an example.<br></div><div> <br></div><div> To enable globally:<br></div><div> <br></div><div> WITH_LTO= yes<br></div><div> <br></div><div> To disable globally (for example ssp is enabled by default):<br></div><div> <br></div><div> WITHOUT_LTO= yes<br></div><div> <br></div><div> To enable for a specific list of ports:<br></div><div> <br></div><div> WITH_LTO_PORTS= lang/perl5.36<br></div><div> <br></div><div> To disable for a specific list of ports:<br></div><div> <br></div><div> WITHOUT_LTO_PORTS= lang/perl5.36<br></div><div> <br></div><div> Differential Revision: <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://reviews.freebsd.org/D44750" target="_blank">https://reviews.freebsd.org/D44750</a><br></div><div>---<br></div><div>; Mk/Uses/<a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://cargo.mk" target="_blank">cargo.mk</a> | 4 +---<br></div><div> Mk/<a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://bsd.port.mk" target="_blank">bsd.port.mk</a> | 42 ++++++++++++++++++++++++++++++++++--------<br></div><div> net-mgmt/net-snmp/Makefile | 2 +-<br></div><div> 3 files changed, 36 insertions(+), 12 deletions(-)<br></div><div><br></div><div>diff --git a/Mk/Uses/<a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://cargo.mk" target="_blank">cargo.mk</a> b/Mk/Uses/<a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://cargo.mk" target="_blank">cargo.mk</a><br></div><div>index e3b733d35821..8710374e3584 100644<br></div><div>--- a/Mk/Uses/<a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://cargo.mk" target="_blank">cargo.mk</a><br></div><div>+++ b/Mk/Uses/<a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://cargo.mk" target="_blank">cargo.mk</a><br></div><div>@@ -139,10 +139,8 @@ CARGO_ENV+= \<br></div><div> CARGO_ENV+= RUST_BACKTRACE=1<br></div><div> . endif<br></div><div> <br></div><div>-. if !defined(_WITHOUT_LTO) && (!defined(WITHOUT_LTO_PORTS) || ${WITHOUT_LTO_PORTS:N${PKGORIGIN}})<br></div><div>+. if defined(WITH_LTO)<br></div><div> _CARGO_MSG= "===> Additional optimization to port applied"<br></div><div>-_WITH_LTO= yes<br></div><div>-.undef _WITHOUT_LTO<br></div><div> . endif <br></div></pre></blockquote></div><div>Hi,<br></div><div><br></div><div>This changes so LTO option is no longer applied to Rust (cargo) ports BY DEFAULT causing a regresssion, please fix.<br></div><div><br></div><div>Best regards,<br></div><div>Daniel<br></div></body></html>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?12af8e210220224883a7856115f61be9>