Date: Sun, 3 Nov 2019 17:31:16 -0800 From: Xin Li <delphij@delphij.net> To: Toomas Soome <tsoome@me.com>, Kevin Bowling <kevin.bowling@kev009.com> Cc: Andriy Gapon <avg@freebsd.org>, Toomas Soome <tsoome@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r354283 - in head: stand/libsa/zfs sys/cddl/boot/zfs Message-ID: <0cb52df0-9128-b3d7-8b56-7ac583b9ad62@delphij.net> In-Reply-To: <51E88C9A-CA94-4503-85F7-8BCD57C00961@me.com> References: <201911031325.xA3DPl3B080386@repo.freebsd.org> <276a3efd-da6c-69ca-cc4f-51c9a5b77696@FreeBSD.org> <CAK7dMtB%2BpVe%2B_A6jAAi1JcVKxHjitQ8fVv5KpxsN=h9ZSZapWw@mail.gmail.com> <51E88C9A-CA94-4503-85F7-8BCD57C00961@me.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ABPXx8qtSk9ArSkQ27f9M4YMTPmsizUmj Content-Type: multipart/mixed; boundary="yuX5ogQ27Ef5KKkIqDmBNGdKzOtKuoEQr"; protected-headers="v1" From: Xin Li <delphij@delphij.net> Reply-To: d@delphij.net To: Toomas Soome <tsoome@me.com>, Kevin Bowling <kevin.bowling@kev009.com> Cc: Andriy Gapon <avg@freebsd.org>, Toomas Soome <tsoome@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <0cb52df0-9128-b3d7-8b56-7ac583b9ad62@delphij.net> Subject: Re: svn commit: r354283 - in head: stand/libsa/zfs sys/cddl/boot/zfs References: <201911031325.xA3DPl3B080386@repo.freebsd.org> <276a3efd-da6c-69ca-cc4f-51c9a5b77696@FreeBSD.org> <CAK7dMtB+pVe+_A6jAAi1JcVKxHjitQ8fVv5KpxsN=h9ZSZapWw@mail.gmail.com> <51E88C9A-CA94-4503-85F7-8BCD57C00961@me.com> In-Reply-To: <51E88C9A-CA94-4503-85F7-8BCD57C00961@me.com> --yuX5ogQ27Ef5KKkIqDmBNGdKzOtKuoEQr Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2019-11-03 13:32, Toomas Soome wrote: >=20 >=20 >> On 3. Nov 2019, at 22:39, Kevin Bowling <kevin.bowling@kev009.com> wro= te: >> >> I believe this is/was a common configuration, at least the few >> spinning disk based systems I have left have a slog. >> >=20 > On boot pool? um. well, I=E2=80=99ll kick out that return then. I think it's fine to simply ignore the log in loader, because it's a read-only consumer. The full-featured kernel ZFS code would skip replaying the log when importing read-only, in that case we might see some outdated data, but it's still guaranteed to be consistent by ZFS. Cheers, >=20 > rgds, > toomas >=20 >> On Sun, Nov 3, 2019 at 10:55 AM Andriy Gapon <avg@freebsd.org> wrote: >>> >>> On 03/11/2019 15:25, Toomas Soome wrote: >>>> Author: tsoome >>>> Date: Sun Nov 3 13:25:47 2019 >>>> New Revision: 354283 >>>> URL: https://svnweb.freebsd.org/changeset/base/354283 >>>> >>>> Log: >>>> loader: we do not support booting from pool with log device >>>> >>>> If pool has log device, stop there and tell about it. >>> >>> Why? >>> >>>> Modified: >>>> head/stand/libsa/zfs/zfs.c >>>> head/stand/libsa/zfs/zfsimpl.c >>>> head/sys/cddl/boot/zfs/zfsimpl.h >>> >>> >>> >>> -- >>> Andriy Gapon >>> _______________________________________________ >>> svn-src-head@freebsd.org mailing list >>> https://lists.freebsd.org/mailman/listinfo/svn-src-head >>> To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.or= g" >=20 --yuX5ogQ27Ef5KKkIqDmBNGdKzOtKuoEQr-- --ABPXx8qtSk9ArSkQ27f9M4YMTPmsizUmj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.2.17 (FreeBSD) iQIzBAEBCgAdFiEEceNg5NEMZIki80nQQHl/fJX0g08FAl2/f2QACgkQQHl/fJX0 g0/0yxAArGEiseHZH0lZvRIc/fuyARzAofV+MYUvG7vVBLsUStlTUVBYmFvyyb4I Zbx5LB1RYTGojIEEg61E/5NXCaXzOBYcGJhNX3cdLSBnP9dPM7W+0xgalqNsVUK4 aM83FXYSEXFneivC3jBn+Oq++gLysNnCX0P7ldbFbZzKHtOndySwvmAhv2zSL3kV OZ6KUwCf8cYHdsw1Ah7adtOMzK1x+T9iNrZ7KTUeWHgnEvN553azjJQRF+58XyZ3 UHKAb1ATH4b3l5V0ZpqxJhj68GUMJuzOgMP2/4q6Co2wYDLfvsakpFHc3fo6ryOz Id+6qfDbAXEU/rPbfRPXoLz7knXU7eDaosMZoMNNWk2W3sqzLmmwrDmmcZKQQEig uVGtu5xyq4jNIf1ANBhN2/NwoaMXuUfrefF0q/yJHANQMdQVFJ511ZWU/U5n76jf LQSzU5cidj/FD5DnxrGEaaMCd1tsZKeywWPFVCYuQ8e7qjHGd1iW9JNmWyN4NJsQ ot6jbUbeKlid/7TuTP5ombn4vrhtWJIeRY3kNd06u8kuF+XInV60tlIu0kbwnFO+ t8P3UDaRyjX28CH1aMVF73qHNqLaW3qN3kNsoN3o9vP8b5Om9tn+TbgN4TO07AAR uhPwYYQyC7ywhAhvzflUl6+XXbJf4ibYt4TBldJojH1VBHwV+ww= =deBN -----END PGP SIGNATURE----- --ABPXx8qtSk9ArSkQ27f9M4YMTPmsizUmj--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0cb52df0-9128-b3d7-8b56-7ac583b9ad62>