Date: Sat, 17 Dec 2022 02:42:42 +0000 From: Jonathan Vasquez <jon@xyinn.org> To: Jonathan Vasquez <jon@xyinn.org> Cc: unkadoug@gmail.com, freebsd-stable@freebsd.org, dougm@freebsd.org Subject: Re: stable/13 - amdgpu broken with n253286-d8a88ec38149 Message-ID: <LH425fr1ZMsJ-3yyoOBsAggZVkvMP0LofnDzkYost3S6PxoQv3LhMPaHtAtz9m_N-GEa-aeJYxyONRjsoHwUDnRaaFsLrrBkDqq4YBTRErk=@xyinn.org> In-Reply-To: <tF26n_rAy1n5HBPeATV01jqnIrjCOACK_kEnhIcPS7iP6Y4oxZASpjQU6h9hhThKIJxY_qfZDVsI81lEn9OtMOOX8rVr3hnyPTIgeyJxPiw=@xyinn.org> References: <snQZb56C8_w6mSKhfRxdwtwB35KXeflnMkLtXKlvMolXWxznSttHh5ihW7ysgYaRKmEmh-EicSa-o5A_SujHCFUzSKUX4gSRRleZbVifJTw=@xyinn.org> <5D2B4EDD-E277-4314-9CA9-CEACC67658DE@gmail.com> <tF26n_rAy1n5HBPeATV01jqnIrjCOACK_kEnhIcPS7iP6Y4oxZASpjQU6h9hhThKIJxY_qfZDVsI81lEn9OtMOOX8rVr3hnyPTIgeyJxPiw=@xyinn.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Oh, I think I understand a bit better what you meant. Yup, after I found which stable/13 commit was problematic, I compiled HEAD~1 which still works, then I recompiled drm-510-kmod and it's working now. But I still wanted to report it since I'm guessing there will need to be some tweaks made to drm-510-kmod so that it works again with the latest stable/13. Jonathan Vasquez PGP: 34DA 858C 1447 509E C77A D49F FB85 90B7 C4CA 5279 Sent with ProtonMail Secure Email ------- Original Message ------- On Friday, December 16th, 2022 at 21:31, Jonathan Vasquez <jon@xyinn.org> wrote: > Hey Doug, > > Not a problem. I actually did clean rebuilds of everything, including pulling the latest ports and cleanly reinstalling drm-510-kmod and gpu-firmware-amd-kmod. But it still failed. > > Jonathan Vasquez > PGP: 34DA 858C 1447 509E C77A D49F FB85 90B7 C4CA 5279 > Sent with ProtonMail Secure Email > > Sent from Proton Mail mobile > > -------- Original Message -------- > On Dec 16, 2022, 21:05, Doug Moore < unkadoug@gmail.com> wrote: > >> Short answer - try rebuilding kmod from scratch. >> >> Long answer - I moved into stable/13 changes from main that changed some binary-level representations. One who found that the kmod he built before those changes no longer worked pointed out my error. So I made a change to stable/13 recently to restore the original representations, and satisfied that person’s complaint. But, someone who built kmod recently will find things broken, the way the original fellow did. I can only apologize and ask you to rebuild non-kernel stuff based on the stable/13 of more than a day ago. I hadn’t considered the impact of my changes on non-kernel code. >> Doug >> >> Sent from my iPad >> >>> On Dec 16, 2022, at 6:50 PM, Jonathan Vasquez <jon@xyinn.org> wrote: >> >>> >>> Hey all, >>> >>> it seems that my AMD Radeon 6900 XT doesn't load the amdgpu properly anymore. The machine will crash immediately upon load. After a bisect, I found the posted commit. This card uses the sienna_cichlid flavor for gpu-firmware-amd-kmod. >>> >>> commit d8a88ec381498f5942403088d28ee325b92e9a78 >>> Author: Doug Moore <dougm@FreeBSD.org> >>> Date: Fri Dec 16 03:15:28 2022 -0600 >>> >>> rb_tree: restore binary compat w/ 13 >>> >>> A change to RB_COLOR_INSERT, when merged into stable/13, broke binary >>> compatibility. For 13, call the new function RB_DO_COLOR_INSERT, and >>> restore the old function with the original name and parameters. Define >>> RB_COLOR_INSERT in tree.h, and remove changes to the linux rbtree >>> header. >>> >>> Another change altered the order of pointers in the RB_ENTRY struct. >>> For 13, restore the original order. >>> >>> Reported by: manu >>> Reviewed by: hselasky >>> Tested by: manu >>> Differential Revision: https://reviews.freebsd.org/D37716 >>> >>> sys/compat/linuxkpi/common/include/linux/rbtree.h | 11 ++---- >>> sys/sys/tree.h | 46 ++++++++++++++++------- >>> >>> Jonathan Vasquez >>> PGP: 34DA 858C 1447 509E C77A D49F FB85 90B7 C4CA 5279 >>> Sent with ProtonMail Secure Email [-- Attachment #2 --] <div style="font-family: Arial; font-size: 14px;">Oh, I think I understand a bit better what you meant. Yup, after I found which stable/13 commit was problematic, I compiled HEAD~1 which still works, then I recompiled drm-510-kmod and it's working now. But I still wanted to report it since I'm guessing there will need to be some tweaks made to drm-510-kmod so that it works again with the latest stable/13. <br></div><div style="font-family: Arial; font-size: 14px;"><br></div> <div class="protonmail_signature_block" style="font-family: Arial; font-size: 14px;"> <div class="protonmail_signature_block-user"> <div>Jonathan Vasquez<br></div><div>PGP: 34DA 858C 1447 509E C77A D49F FB85 90B7 C4CA 5279<br></div><div>Sent with ProtonMail Secure Email<br></div><div><br></div> </div> <div class="protonmail_signature_block-proton protonmail_signature_block-empty"> </div> </div> <div style="font-family: Arial; font-size: 14px;"><br></div><div class="protonmail_quote"> ------- Original Message -------<br> On Friday, December 16th, 2022 at 21:31, Jonathan Vasquez <jon@xyinn.org> wrote:<br><br> <blockquote class="protonmail_quote" type="cite"> Hey Doug,<br><br>Not a problem. I actually did clean rebuilds of everything, including pulling the latest ports and cleanly reinstalling drm-510-kmod and gpu-firmware-amd-kmod. But it still failed. <br><br><br><div>Jonathan Vasquez<br></div><div>PGP: 34DA 858C 1447 509E C77A D49F FB85 90B7 C4CA 5279<br></div><div>Sent with ProtonMail Secure Email<br></div><div><br></div><br><br>Sent from Proton Mail mobile<br><br><br><br>-------- Original Message --------<br>On Dec 16, 2022, 21:05, Doug Moore < unkadoug@gmail.com> wrote:<blockquote class="protonmail_quote"><br>Short answer - try rebuilding kmod from scratch.<div><br></div><div>Long answer - I moved into stable/13 changes from main that changed some binary-level representations. One who found that the kmod he built before those changes no longer worked pointed out my error. So I made a change to stable/13 recently to restore the original representations, and satisfied that person’s complaint. But, someone who built kmod recently will find things broken, the way the original fellow did. I can only apologize and ask you to rebuild non-kernel stuff based on the stable/13 of more than a day ago. I hadn’t considered the impact of my changes on non-kernel code.</div><div>Doug<br><br><div dir="ltr">Sent from my iPad</div><div dir="ltr"><br><blockquote type="cite">On Dec 16, 2022, at 6:50 PM, Jonathan Vasquez <jon@xyinn.org> wrote:<br><br></blockquote></div><blockquote type="cite"><div dir="ltr"><div style="font-family: Arial; font-size: 14px;"><span>Hey all,</span></div><div style="font-family: Arial; font-size: 14px;"><span><br></span></div><div style="font-family: Arial; font-size: 14px;"><span>it seems that my AMD Radeon 6900 XT doesn't load the amdgpu properly anymore. The machine will crash immediately upon load. After a bisect, I found the posted commit. This card uses the <code>sienna_cichlid</code> flavor for gpu-firmware-amd-kmod.<br></span></div><div style="font-family: Arial; font-size: 14px;"><span><br></span></div><div style="font-family: Arial; font-size: 14px;"><span>commit d8a88ec381498f5942403088d28ee325b92e9a78</span><div><span>Author: Doug Moore <<a href="mailto:dougm@FreeBSD.org" rel="noreferrer nofollow noopener" target="_blank">dougm@FreeBSD.org</a>></span></div><div><span>Date: Fri Dec 16 03:15:28 2022 -0600</span></div><div><br></div><div><span> rb_tree: restore binary compat w/ 13</span></div><div><span> </span></div><div><span> A change to RB_COLOR_INSERT, when merged into stable/13, broke binary</span></div><div><span> compatibility. For 13, call the new function RB_DO_COLOR_INSERT, and</span></div><div><span> restore the old function with the original name and parameters. Define</span></div><div><span> RB_COLOR_INSERT in tree.h, and remove changes to the linux rbtree</span></div><div><span> header.</span></div><div><span> </span></div><div><span> Another change altered the order of pointers in the RB_ENTRY struct.</span></div><div><span> For 13, restore the original order.</span></div><div><span> </span></div><div><span> Reported by: manu</span></div><div><span> Reviewed by: hselasky</span></div><div><span> Tested by: manu</span></div><div><span> Differential Revision: <a href="https://reviews.freebsd.org/D37716" rel="noreferrer nofollow noopener" target="_blank">https://reviews.freebsd.org/D37716</a></span></div><div><br></div><div><span> sys/compat/linuxkpi/common/include/linux/rbtree.h | 11 ++----</span></div><div><span> sys/sys/tree.h | 46 ++++++++++++++++-------</span></div><span></span><br></div><div style="font-family: Arial; font-size: 14px;"><br></div> <div style="font-family: Arial; font-size: 14px;" class="protonmail_signature_block"> <div class="protonmail_signature_block-user"> <div>Jonathan Vasquez<br></div><div>PGP: 34DA 858C 1447 509E C77A D49F FB85 90B7 C4CA 5279<br></div><div>Sent with ProtonMail Secure Email<br></div><div><br></div> </div> <div class="protonmail_signature_block-proton protonmail_signature_block-empty"> </div> </div> </div></blockquote></div></blockquote> </blockquote><br> </div>help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?LH425fr1ZMsJ-3yyoOBsAggZVkvMP0LofnDzkYost3S6PxoQv3LhMPaHtAtz9m_N-GEa-aeJYxyONRjsoHwUDnRaaFsLrrBkDqq4YBTRErk=>