Date: Mon, 27 Apr 2026 19:21:36 +0000 From: Ed Maste <emaste@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: ea27ec183d0f - main - makeman.lua: Downgrade `make showconfig` error to warning Message-ID: <69efb740.3006d.45c2aff2@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=ea27ec183d0ff26e1273202841a02041b6d93955 commit ea27ec183d0ff26e1273202841a02041b6d93955 Author: Ed Maste <emaste@FreeBSD.org> AuthorDate: 2026-04-26 19:30:17 +0000 Commit: Ed Maste <emaste@FreeBSD.org> CommitDate: 2026-04-27 19:21:12 +0000 makeman.lua: Downgrade `make showconfig` error to warning The sh-based makeman silently ignored errors from `make showconfig`. Ignore errors also from makeman.lua (but emit a warning). We may want to revisit this in the future, but want makeman.lua to behave identically for now. PR: 294822 Reviewed by: kevans Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D56663 --- tools/build/options/makeman.lua | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/build/options/makeman.lua b/tools/build/options/makeman.lua index af641ff6d638..a7b577d76efb 100644 --- a/tools/build/options/makeman.lua +++ b/tools/build/options/makeman.lua @@ -192,7 +192,10 @@ local function run_make(args) local _, exit_type, exit_code = assert(sys_wait.wait(pid)) assert(exit_type == "exited", "make exited with wrong status") - assert(exit_code == 0, "make exited unsuccessfully") + if exit_code ~= 0 then + io.stderr:write("Warning: make exited unsuccessfully\n" .. + "cmd: make " .. table.concat(args, " ") .. "\n") + end return output endhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?69efb740.3006d.45c2aff2>