Date: Thu, 20 Oct 2005 20:41:01 GMT From: Todd Miller <millert@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 85619 for review Message-ID: <200510202041.j9KKf1a0024660@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=85619 Change 85619 by millert@millert_ibook on 2005/10/20 20:40:53 GFP_ATOMIC should really be defined as M_NOWAIT but this causes a panic in the zone allocator from avc_init(). Make it M_WAITOK for now and document the problem. Since sebsd_malloc() didn't honor M_WAITOK before, this effectively changes things back to the way they were, but hopefully in a less confusing manner. We may need to investigate using a lower level allocator here. Affected files ... .. //depot/projects/trustedbsd/sedarwin7/src/sedarwin/sedarwin/linux-compat.h#5 edit Differences ... ==== //depot/projects/trustedbsd/sedarwin7/src/sedarwin/sedarwin/linux-compat.h#5 (text+ko) ==== @@ -136,8 +136,9 @@ #define kmalloc(size,flags) sebsd_ss_malloc(size, flags) #define kfree(v) sebsd_ss_free(v) #define __get_free_page(flags) sebsd_ss_malloc(PAGE_SIZE, flags) -#define GFP_ATOMIC M_NOWAIT -#define GFP_KERNEL M_NOWAIT +/* XXX - GFP_ATOMIC should be M_NOWAIT but zone alloc chokes in avc init */ +#define GFP_ATOMIC M_WAITOK +#define GFP_KERNEL M_WAITOK #ifdef __APPLE__ /* TBD: Skip this for now: */
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200510202041.j9KKf1a0024660>