Date: Mon, 19 Sep 2016 14:23:53 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: "Conrad E. Meyer" <cem@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r305998 - in head/usr.bin: cmp indent tr Message-ID: <7087F928-F8AB-499F-8D73-92B29FB20494@gmail.com> In-Reply-To: <8333248.dV1m5xp1ki@ralph.baldwin.cx> References: <201609192043.u8JKh3jv040006@repo.freebsd.org> <E52FB33D-0921-404F-8457-0E2CB957556B@gmail.com> <8333248.dV1m5xp1ki@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Sep 19, 2016, at 2:22 PM, John Baldwin <jhb@freebsd.org> wrote: > > On Monday, September 19, 2016 01:45:01 PM Ngie Cooper wrote: >> >>> On Sep 19, 2016, at 1:43 PM, Conrad E. Meyer <cem@FreeBSD.org> wrote: >>> >>> Author: cem >>> Date: Mon Sep 19 20:43:03 2016 >>> New Revision: 305998 >>> URL: https://svnweb.freebsd.org/changeset/base/305998 >>> >>> Log: >>> Move sys/capsicum.h includes after types.h or param.h >>> >>> This is not actually documented or even implied in style(9). Make the change >>> to match convention. Someone should document this convention in style(9). >>> >>> Reported by: jhb >>> Sponsored by: EMC Dell Isilon >> >> Uh… yes it clearly states it in style(9). From https://www.freebsd.org/cgi/man.cgi?query=style&sektion=9 : >> Kernel include files (i.e. sys/*.h) come first; normally, include >> <sys/types.h> OR <sys/param.h>, but not both. <sys/types.h> includes >> <sys/cdefs.h>, and it is okay to depend on that. > > It doesn't actually say that types.h/param.h has to come before other sys/*.h > headers though. Normally sys/foo.h requires sys/types.h to compile hence the > rule, but sys/capsicum.h gets around this by a nested include of sys/param.h > (which is itself probably dubious). > > I do think we should explicitly add a note to style.9 though to say that > types.h|param.h comes first. Yeah… I just reread it and I noticed that it’s not 100% explicit. Thanks, -Ngie
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7087F928-F8AB-499F-8D73-92B29FB20494>