Date: Thu, 1 Sep 2016 06:32:53 +0000 From: Phabricator <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] D7710: net/vlan: Shift for pri is 13 (pri mask 0xe000) not 1. Message-ID: <c52f3b8dbb890bff3ab0ded4f31d12b1@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-lziieihxpwqamp6uiaam-req@FreeBSD.org> References: <differential-rev-PHID-DREV-lziieihxpwqamp6uiaam-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] This revision was automatically updated to reflect the committed changes. Closed by commit rS305177: net/vlan: Shift for pri is 13 (pri mask 0xe000) not 1. (authored by sephe). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D7710?vs=19837&id=19914#toc REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D7710?vs=19837&id=19914 REVISION DETAIL https://reviews.freebsd.org/D7710 AFFECTED FILES head/sys/net/ethernet.h CHANGE DETAILS diff --git a/head/sys/net/ethernet.h b/head/sys/net/ethernet.h --- a/head/sys/net/ethernet.h +++ b/head/sys/net/ethernet.h @@ -92,7 +92,7 @@ #define EVL_PRIOFTAG(tag) (((tag) >> 13) & 7) #define EVL_CFIOFTAG(tag) (((tag) >> 12) & 1) #define EVL_MAKETAG(vlid, pri, cfi) \ - ((((((pri) & 7) << 1) | ((cfi) & 1)) << 12) | ((vlid) & EVL_VLID_MASK)) + ((((((pri) & 7) << 13) | ((cfi) & 1)) << 12) | ((vlid) & EVL_VLID_MASK)) /* * NOTE: 0x0000-0x05DC (0..1500) are generally IEEE 802.3 length fields. EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sepherosa_gmail.com, glebius, bz, gnn, rwatson, bms, araujo, hselasky Cc: hselasky, freebsd-net-list [-- Attachment #2 --] diff --git a/head/sys/net/ethernet.h b/head/sys/net/ethernet.h --- a/head/sys/net/ethernet.h +++ b/head/sys/net/ethernet.h @@ -92,7 +92,7 @@ #define EVL_PRIOFTAG(tag) (((tag) >> 13) & 7) #define EVL_CFIOFTAG(tag) (((tag) >> 12) & 1) #define EVL_MAKETAG(vlid, pri, cfi) \ - ((((((pri) & 7) << 1) | ((cfi) & 1)) << 12) | ((vlid) & EVL_VLID_MASK)) + ((((((pri) & 7) << 13) | ((cfi) & 1)) << 12) | ((vlid) & EVL_VLID_MASK)) /* * NOTE: 0x0000-0x05DC (0..1500) are generally IEEE 802.3 length fields.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c52f3b8dbb890bff3ab0ded4f31d12b1>