Date: Wed, 20 Nov 2013 17:29:37 -0500 From: George Neville-Neil <gnn@freebsd.org> To: Adrian Chadd <adrian@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, FreeBSD Net <freebsd-net@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "freebsd-arch@freebsd.org" <freebsd-arch@freebsd.org> Subject: Re: svn commit: r258328 - head/sys/net Message-ID: <023E719B-1059-4670-8556-EBAC18A2F007@freebsd.org> In-Reply-To: <CAJ-VmomjQrq39jafTTGQA_EJLSi5j%2BNB=g1sLwCK-KaEfgwrbw@mail.gmail.com> References: <201311182258.rAIMwEFd048783@svn.freebsd.org> <CAJ-VmomjQrq39jafTTGQA_EJLSi5j%2BNB=g1sLwCK-KaEfgwrbw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_E7352C3B-1624-44C1-8794-7B37258E98DD Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Nov 20, 2013, at 17:02 , Adrian Chadd <adrian@freebsd.org> wrote: > Can we revert this and just quickly put together something else that > won't potentially come back to bite us with weird side effects? >=20 > My suggestions (and I'm happy to do this work if needed): >=20 > * create a lightweight mbuf queue representation so an mbuf list isn't > just the mbuf header pointer; > * create a new ether input (say, ether_input_multi) that takes an mbuf > list, so existing driver code does the right thing. >=20 > After that it'd be nice to write a set of mbuf list macros for > abstract the whole queue, dequeue, concat, iterate, etc (like > sys/queue.h, but for mbufs.) >=20 > What do people think? >=20 > (I've been doing it for m->next chained things, but not m->m_nextpkt = things..) I think the right way to do this is to move forwards and not backwards. This change has the nice effect of not breaking anything else in the tree while providing us with a feature that will be useful. =20 If you want to add an ether_input_multi() that might make sense as an adjunct to what=92s there now. Best, Geoge =20 --Apple-Mail=_E7352C3B-1624-44C1-8794-7B37258E98DD Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org iEYEARECAAYFAlKNN9EACgkQYdh2wUQKM9IhNwCgxNJQY383jR+pHPAg6DuJc4/a O4wAnirp4BKvFIPw48tB7ddl+po7Fb2G =YkRf -----END PGP SIGNATURE----- --Apple-Mail=_E7352C3B-1624-44C1-8794-7B37258E98DD--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?023E719B-1059-4670-8556-EBAC18A2F007>