Date: Wed, 23 Feb 2005 01:41:01 -0500 (EST) From: Jeff Roberson <jroberson@chesapeake.net> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys vnode.h Message-ID: <20050223014018.Y52537@mail.chesapeake.net> In-Reply-To: <58139.1109140240@critter.freebsd.dk> References: <58139.1109140240@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 23 Feb 2005, Poul-Henning Kamp wrote: > In message <20050222180223.V52537@mail.chesapeake.net>, Jeff Roberson writes: > >On Tue, 22 Feb 2005, Poul-Henning Kamp wrote: > > > >> phk 2005-02-22 18:49:03 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/sys vnode.h > >> Log: > >> Group the fields in struct vnode by their function and stick comments > >> there to tell what the function is. > > > >They were sorted according to the lock that they used. I still prefer > >that, prehaps with sorting by use secondly. > > That doesn't make sense. The comment says which lock they use so people > can still see that, but appearantly people had big trouble seeing what > fields belonged where. It was so that we minimize cache hits, and cause a minimum number of synchronized writes when we release the mutex. > > -- > Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 > phk@FreeBSD.ORG | TCP/IP since RFC 956 > FreeBSD committer | BSD since 4.3-tahoe > Never attribute to malice what can adequately be explained by incompetence. >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050223014018.Y52537>