Date: Thu, 04 Apr 2002 01:03:29 -0600 From: "Jeffrey J. Mountin" <jeff-ml@mountin.net> To: Hajimu UMEMOTO <ume@mahoroba.org> Cc: <freebsd-stable@FreeBSD.ORG> Subject: Re: src-sys-crypto and src-all (was des_enc.S) Message-ID: <4.3.2.20020404001342.024989d0@207.227.119.2> In-Reply-To: <ygelmc41b1y.wl@cheer.mahoroba.org> References: <20020403115912.S96916-100000@mx.dmz.orem.verio.net> <yge4riswt2e.wl@mille.mahoroba.org> <20020403115912.S96916-100000@mx.dmz.orem.verio.net>
next in thread | previous in thread | raw e-mail | index | archive | help
At 10:56 AM 4/4/02 +0900, Hajimu UMEMOTO wrote: >Hi, > > >>>>> On Wed, 3 Apr 2002 12:06:03 -0700 (MST) > >>>>> Aaron Mildenstein <aaronm@orem.verio.net> said: > >aaronm> Ah. src-all >aaronm> I had set up cvsup with the cvsupit tool in the ports collection >when I >aaronm> first started using cvs (back in 4.0 days). It had me select what >lines I >aaronm> wanted to use, ie. src-games, src-sys, etc, and then I had a 20+ line >aaronm> cvsupfile. I have been transplanting that file on all of my FreeBSD >aaronm> machines since then, and had been unaware that src-sys-crypto had been >aaronm> added, or that there was even a src-all option for cvsupfile. Perhaps >aaronm> more attention should be given this, as it was a fairly recent >(pre 4.5 >aaronm> release, I never had a problem) change. > >The smbfs.ko module was newly added into 4-STABLE since 4.4-RELEASE. >If you have src/sys/crypto in your src tree, smbfs.ko will be compiled >with DES support. >Recently, new module (des_enc.S) was added into src/sys/crypto and >smbfs.ko requires it. >It seems you had src/sys/crypto in your src tree but you didn't do >CVSup for src-sys-crypto collection. Actually it has been around required for longer than that (month after 4.3R): http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/modules/smbfs/Makefile The src-sys-crypto collection dates back to 3.x days. Not sure when cvsupit (or if) added it, but it has been in the examples for quite a while now. While one would not expect the collections to change (ports is one exception) we should be past this one by now. Perhaps there should be either some more information for CVSup in the handbook such as the minimal list required with a stock make.conf and/or comments after each collection the examples, which I've suggested in the past. Adding info on what knobs in make.conf require a collection (eg Kerberos) would be better suited to the handbook, but having the minimalist ones in the examples should help avoid this coming up time after time. Also don't like how it looks like another "src-all" due to the last comment lines. Just a small nit. While it suggests that src-all be used to track -stable, a 2 line note couldn't hurt along with a comment/tag after the collections (not sure if that's legit - jdp/cvsmeisters?). As the cvs-crypto collection is dead, is the last comment really needed anymore. Would understand keeping it around until 5.0R might not hurt. Pointing out the legality in some countries would be the only reason not to sort them in with the others (actually then src-crypto and src-secure should be moved) and leave the comment and change it appropriately. Jeff Mountin - jeff@mountin.net Systems/Network Administrator FreeBSD - the power to serve To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4.3.2.20020404001342.024989d0>