Date: Thu, 2 Feb 2023 19:12:29 -0700 From: Warner Losh <imp@bsdimp.com> To: freebsd-git <freebsd-git@freebsd.org> Subject: Proposed Github Pull Request Policy Message-ID: <CANCZdfq_=pDon8LmhjV%2BWyPsGcuG1hp3LrfxXe9mJ51J0P2iqg@mail.gmail.com>
next in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Geetngs, I'd like to put some parameters around the pull requests on github. To that end, I'd like us to consider the following policy: In general, pull requests should be small, easily reviewable and solve real problems. The pull requests should be small enough that developers can look at them and decide quickly if the request should be (a) committed (b) revised or (c) rejected. To that end: Please limit pull requests to about 200 or so lines of changes, spread across no more than 10 commits. Each independent change should get a new pull request (though groups of closely related changes should be in one). Subitter should be responsive to feedback. The pull requests should be changes that are ready to land in the tree (or nearly so, based on review). Pull requests shouldn't expand in scope in response to feedback: If the feedback suggests a new series of changes, please create a new pull requests. Do not submit 'omnibus' branches that have no unifying theme. Please respect requests to take reviews to phabricator, and close the pull request on github when you do that. Please do not submit pull requests that don't conform to these guidelines unless you have a good reason, like: (1) You are arranging with others to do the review on github. (2) The review is a poor fit for phabricator, but a good fit for github Idle pull requests that are outside of these guidelines will be closed. [-- Attachment #2 --] <div dir="ltr"><div>Geetngs,</div><div><br></div><div>I'd like to put some parameters around the pull requests on github. To that end, I'd like us to consider the following policy:</div><div><br></div><div>In general, pull requests should be small, easily reviewable and solve real problems. The pull requests should be small enough that developers can look at them and decide quickly if the request should be (a) committed (b) revised or (c) rejected.<br></div><div><br></div><div>To that end:</div><div><br></div><div>Please limit pull requests to about 200 or so lines of changes, spread across no more than 10 commits. Each independent change should get a new pull request (though groups of closely related changes should be in one). Subitter should be responsive to feedback. The pull requests should be changes that are ready to land in the tree (or nearly so, based on review).</div><div><br></div><div>Pull requests shouldn't expand in scope in response to feedback: If the feedback suggests a new series of changes, please create a new pull requests.</div><div><br></div><div>Do not submit 'omnibus' branches that have no unifying theme.</div><div><br></div><div>Please respect requests to take reviews to phabricator, and close the pull request on github when you do that.<br></div><div><br></div><div>Please do not submit pull requests that don't conform to these guidelines unless you have a good reason, like:</div><div>(1) You are arranging with others to do the review on github.</div><div>(2) The review is a poor fit for phabricator, but a good fit for github</div><div><br></div><div>Idle pull requests that are outside of these guidelines will be closed.</div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfq_=pDon8LmhjV%2BWyPsGcuG1hp3LrfxXe9mJ51J0P2iqg>