Date: Tue, 22 Jan 2019 12:40:31 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 231806] [NEW PORT] math/libnormaliz: computations in affin monoids, vector configurations etc Message-ID: <bug-231806-7788-FHw1JmGjXg@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-231806-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-231806-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D231806 --- Comment #8 from Tobias Kortkamp <tobik@freebsd.org> --- Comment on attachment 197690 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D197690 shar file of libnormaliz - correction 3 I do not understand what the flavors are supposed to do. Can you explain what the intent behind them is here? XBUILD_WRKSRC=3D ${WRKSRC}/source/libnormaliz XINSTALL_WRKSRC=3D ${WRKSRC}/source/libnormaliz X XCXXFLAGS+=3D -I ${LOCALBASE}/include XMAKEFILE=3D Makefile.classic These are all framework variables and in the wrong place. XHEADERSDIR=3D ${PREFIX}/include/libnormaliz This custom variable is only used twice. Maybe inline it instead. X for x in cone.h cone_property.h convert.h general.h HilbertSeries.h integer.h libnormaliz.h map_operations.h matrix.h my_omp.h normaliz_excepti= on.h sublattice_representation.h vector_operations.h version.h nmz_integrate.h; = do ${INSTALL_DATA} ${INSTALL_WRKSRC}/$$x ${STAGEDIR}${HEADERSDIR}; done It would be better to use a .for loop here, or even without one at all like cd ${INSTALL_WRKSRC} && ${INSTALL_DATA} cone.h cone_propery.h ... ${STAGEDIR}${PREFIX}/include/libnormaliz pkg-plist is badly ordered. Please use the order as output by `make makeplist`. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-231806-7788-FHw1JmGjXg>