Date: Sun, 17 Dec 2006 13:05:49 -0800 From: Alfred Perlstein <alfred@freebsd.org> To: Kip Macy <kmacy@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 apic_vector.s exception.s local_apic.c trap.c vm86.c vm86bios.s src/sys/i386/include apicvar.h src/sys/i386/isa atpic.c atpic_vector.s icu.h Message-ID: <20061217210549.GG70403@elvis.mu.org> In-Reply-To: <200612170507.kBH572Ff008476@repoman.freebsd.org> References: <200612170507.kBH572Ff008476@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I think that reliance on this dates back to before FreeBSD. It's interesting to see it gone. * Kip Macy <kmacy@FreeBSD.org> [061216 21:07] wrote: > kmacy 2006-12-17 05:07:01 UTC > > FreeBSD src repository > > Modified files: > sys/i386/i386 apic_vector.s exception.s local_apic.c > trap.c vm86.c vm86bios.s > sys/i386/include apicvar.h > sys/i386/isa atpic.c atpic_vector.s icu.h > Log: > Evidently FreeBSD has long relied on the compiler to treat structures > passed by value (trap frames) as if they were in fact being passed by > reference. For better or worse, this incorrect behaviour is no longer > present in gcc 4.1. In this patch I convert all trapframe arguments to > be explicitly pass by reference. I also remove vm86_initflags, pushing > the very little work that it actually does up into vm86_prepcall.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061217210549.GG70403>