Date: Sat, 9 Mar 2024 20:11:23 +0800 From: Po-Chuan Hsieh <sunpoet@freebsd.org> To: Daniel Engberg <daniel.engberg.lists@pyret.net> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 450aafcba559 - main - textproc/tinyxml2: Update to 10.0.0 Message-ID: <CAMHz58Q_L-t9X05rGt-x8B55f-%2BNYWxo5CRaS-iQ9HPm1Y2AEg@mail.gmail.com> In-Reply-To: <9ea613e41885bc4b8cab826a1d5508da@mail.infomaniak.com> References: <202402211520.41LFK8mS022399@gitrepo.freebsd.org> <9ea613e41885bc4b8cab826a1d5508da@mail.infomaniak.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Fri, Feb 23, 2024 at 5:23 AM Daniel Engberg < daniel.engberg.lists@pyret.net> wrote: > On 2024-02-21T16:20:08.000+01:00, Po-Chuan Hsieh <sunpoet@FreeBSD.org> > wrote: > > The branch main has been updated by sunpoet: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=450aafcba559f95c94c5f195d83b5fe4fdc3748a > > commit 450aafcba559f95c94c5f195d83b5fe4fdc3748a > Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org> > AuthorDate: 2024-02-21 14:29:27 +0000 > Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org> > CommitDate: 2024-02-21 15:06:47 +0000 > > textproc/tinyxml2: Update to 10.0.0 > > - Convert to meson > - Fix 0c022f0fc854184d95ff3303049a063a39b1f551 > - Bump PORTREVISION for package change > - Bump PORTREVISION of dependent ports for shlib change > - Remove duplicate PORTREVISION from math/linbox > > Changes: https://github.com/leethomason/tinyxml2/releases > https://github.com/leethomason/tinyxml2/commits/master > --- > > Hi, > > Please explain what you fixed as this change makes consumers utilizing > CMake to find (lib)tinyxml2 now requiring patching when they worked fine > before your change? > > Your patch for net/ecal is not a fix but a workaround for something that > broke by this commit. > > Here's a build log of said port and the PR related. > > https://pdr2.bofh.network/data/132-diizzy/2024-01-01_11h58m45s/logs/ecal-5.12.1_3.log > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277227 > > Best regards, > Daniel > Hello, Obviously you did not handle the dependent ports which encounter shlib change. Enforce port A to use cmake because port B uses cmake. This behavior is toxic. It works like a virus. Regarding net/ecal, please explicitly point out what is the broken in net/ecal. If you mean something like "(ecal-5.12.1_3) /wrkdirs/usr/ports/net/ecal/work/stage//usr/local/bin/ecal_mon_gui-5.12.1 - required shared library libCustomQt.so not found", I see nothing related with tinyxml2's cmake script. Not to mention that I see the same message when tinyxml2 is built with cmake. The cmake problem is misleading information. Regards, sunpoet [-- Attachment #2 --] <div dir="ltr"><div dir="ltr">On Fri, Feb 23, 2024 at 5:23 AM Daniel Engberg <<a href="mailto:daniel.engberg.lists@pyret.net" target="_blank">daniel.engberg.lists@pyret.net</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div>On 2024-02-21T16:20:08.000+01:00, Po-Chuan Hsieh <sunpoet@FreeBSD.org> wrote:<br></div><div><blockquote><pre style="white-space:normal"><div>The branch main has been updated by sunpoet:<br></div><div><br></div><div>URL: <a rel="noopener noreferrer" href="https://cgit.FreeBSD.org/ports/commit/?id=450aafcba559f95c94c5f195d83b5fe4fdc3748a" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=450aafcba559f95c94c5f195d83b5fe4fdc3748a</a><br></div><div><br></div><div>commit 450aafcba559f95c94c5f195d83b5fe4fdc3748a<br></div><div>Author: Po-Chuan Hsieh <<a href="mailto:sunpoet@FreeBSD.org" target="_blank">sunpoet@FreeBSD.org</a>><br></div><div>AuthorDate: 2024-02-21 14:29:27 +0000<br></div><div>Commit: Po-Chuan Hsieh <<a href="mailto:sunpoet@FreeBSD.org" target="_blank">sunpoet@FreeBSD.org</a>><br></div><div>CommitDate: 2024-02-21 15:06:47 +0000<br></div><div><br></div><div> textproc/tinyxml2: Update to 10.0.0<br></div><div> <br></div><div> - Convert to meson<br></div><div> - Fix 0c022f0fc854184d95ff3303049a063a39b1f551<br></div><div> - Bump PORTREVISION for package change<br></div><div> - Bump PORTREVISION of dependent ports for shlib change<br></div><div> - Remove duplicate PORTREVISION from math/linbox<br></div><div> <br></div><div> Changes: <a rel="noopener noreferrer" href="https://github.com/leethomason/tinyxml2/releases" target="_blank">https://github.com/leethomason/tinyxml2/releases</a><br></div><div>; <a rel="noopener noreferrer" href="https://github.com/leethomason/tinyxml2/commits/master" target="_blank">https://github.com/leethomason/tinyxml2/commits/master</a><br></div><div>---</div></pre></blockquote></div><div>Hi,<br></div><div><br></div><div>Please explain what you fixed as this change makes consumers utilizing CMake to find (lib)tinyxml2 now requiring patching when they worked fine before your change?<br></div><div><br></div><div>Your patch for net/ecal is not a fix but a workaround for something that broke by this commit.<br></div><div><br></div><div>Here's a build log of said port and the PR related.<br></div><div><a href="https://pdr2.bofh.network/data/132-diizzy/2024-01-01_11h58m45s/logs/ecal-5.12.1_3.log" target="_blank">https://pdr2.bofh.network/data/132-diizzy/2024-01-01_11h58m45s/logs/ecal-5.12.1_3.log</a><br></div><div><br></div><div><a href="https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277227" target="_blank">https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277227</a><br></div><div><br></div><div>Best regards,<br></div><div>Daniel</div></blockquote><div><br></div><div>Hello,</div><div><br></div><div>Obviously you did not handle the dependent ports which encounter shlib change.</div><div><br></div><div>Enforce port A to use cmake because port B uses cmake.</div><div>This behavior is toxic. It works like a virus.</div><div><br></div><div>Regarding net/ecal, please explicitly point out what is the broken in net/ecal.</div><div>If you mean something like "(ecal-5.12.1_3) /wrkdirs/usr/ports/net/ecal/work/stage//usr/local/bin/ecal_mon_gui-5.12.1 - required shared library libCustomQt.so not found", I see nothing related with tinyxml2's cmake script.</div><div>Not to mention that I see the same message when tinyxml2 is built with cmake.<br></div><div><br></div><div>The cmake problem is misleading information.<br></div><div><br></div><div>Regards,</div><div>sunpoet</div></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58Q_L-t9X05rGt-x8B55f-%2BNYWxo5CRaS-iQ9HPm1Y2AEg>