Date: Mon, 12 Apr 2021 13:04:07 +0200 From: Mathieu Arnold <mat@freebsd.org> To: Yuri <yuri@freebsd.org> Cc: Gerald Pfeifer <gerald@pfeifer.com>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: eec439ed34be - main - audio/madronalib: Add USES=compiler:c++11-lib Message-ID: <20210412110407.4c5xvkzeyug5rt2q@aching.in.mat.cc> In-Reply-To: <5aecd80f-0b68-8a43-e460-a46bedebf5bb@rawbw.com> References: <202104092224.139MOrxt005624@gitrepo.freebsd.org> <7341e8b1-db98-1e35-3654-1441ddaac9fa@pfeifer.com> <5aecd80f-0b68-8a43-e460-a46bedebf5bb@rawbw.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--5k3kqqtf2fxgu2yb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 12, 2021 at 01:34:41AM -0700, Yuri wrote: > On 4/10/21 1:36 PM, Gerald Pfeifer wrote: > > Why that? I'm not saying it is wrong - it just would be helpful > > to briefly explain the reason behind such a change. >=20 > compiler:c++11-lib was forgotten. It is only needed on non-Intel platforms > and is easy to overlook. Then please write that in your commit message. A commit message must express the WHY, anyone can read the the diff. --=20 Mathieu Arnold --5k3kqqtf2fxgu2yb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAmB0KRJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2 MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd fgIgUxAAkY9K86KZlNfB+t4z3CUCID3StDefc0Dmr3BWvAQBQTloJpb+KswRK8ud MgUArkvSi8rgZgZTqnhFV3gPgwvBIKMUtbwD44uW4JE+smb93+QlqmIvuUGkQIL6 xZbgDwrY7Rx7Ap4Kpb7iF+f5eVOGmR3zjf9uP3bbc/amXUfqcrztcCRpKjfq4zbx zGt2fxoEhnAtbPyen+p5W1vzt6ENKG51/UUFl0dbDEKVwbxLpCOIgKoY+Qg3CimP 6XMHJ522CdVQGcyxL7gn+vLIpZXSI000RQJLO4KpXUm3DPG4STUb0hvR8yYj8xH6 J72flADlmOEFCNGww+ilEo7KBM0X7Mrrobq8TmOvjBHSZAFWALQHXNabNxfZKg7q qLASdVc/8hGzqt2d5yZgELuOakySIe2Es5E+Fucyg43GrR0J6LEPhb8e5PO3U1z8 YC1mNBsbq77OPg1HbR9OR4N+u/Cr1maJxUgyg2juG70nU56UfVnrUj2J5RQW3I1b RgdMLuJdYcsuJ1zIgZWFp8FoOx/mbaMA6pHQe7vl9MHFbULexBdx6IoF/d6RT3HG htXk44SVmgEphXU9sOqIm6YVDmDzuG2tlmChZJ7Tprnnpr9BP8dVecFU6PbDkIOs l4tT+hEvAc2qNtNZMlCYRtpljEaLGYjfpEVM4f4raEP0kBa/y3w= =B/hs -----END PGP SIGNATURE----- --5k3kqqtf2fxgu2yb--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210412110407.4c5xvkzeyug5rt2q>