Date: Tue, 24 Nov 2020 12:06:36 +0300 From: Yuri Pankov <yuripv@yuripv.dev> To: rhurlin@FreeBSD.org, freebsd-ports@FreeBSD.org Subject: Re: Portlint complains about %%FOO%% in PLIST_FILES Message-ID: <988ea1b1-fb58-55b9-43ff-6086e09f5894@yuripv.dev> In-Reply-To: <50337e9b-ab50-6877-a5a6-213006f2195e@gwdg.de> References: <50337e9b-ab50-6877-a5a6-213006f2195e@gwdg.de>
next in thread | previous in thread | raw e-mail | index | archive | help
Rainer Hurling wrote:
> Yesterday I committed net/hblock [r556099] after changing the patch to
> PLIST_FILES (instead of pkg-plist with only two files) against the
> suggestion of the submitter.The line in question is:
>
> PLIST_FILES=bin/${PORTNAME} %%MANPAGES%%man/man1/hblock.1.gz
>
>
> I made this change because it allows the port to build and install
> correctly in all combinations of OPTIONS.
>
> With the use of %%MANPAGES%%% in PLIST_FILES one can selectively enable
> and disable the building of manpages.
>
> The maintainer of net/hblock informs me about a problem with using
> %%MANPAGES%% in PLIST_FILES. I don't know why I did not notice the
> message from 'portlint -AC' before:
>
> FATAL: PLIST_FILES: files cannot contain %%FOO%% variables. Use make
> variables and logic instead
>
>
> Is it possibly correct to use %%MANPAGES%% in PLIST_FILES and only
> portlint can't handle it?
>
> Is there an alternative to switching back to pkg-plist file?
>
>
> Thanks in advance for clarification and maybe a suggestion for correct
> usage.
See 5.13.3.11 in
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-options.html,
i.e. use MANPAGES_PLIST_FILES=.
See x11/swaybg/Makefile for example.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?988ea1b1-fb58-55b9-43ff-6086e09f5894>