Date: Mon, 08 Jun 2009 17:44:50 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: rea-fbsd@codelabs.ru Cc: amd64@FreeBSD.org, current@FreeBSD.org Subject: Re: [head tinderbox] failure on amd64/amd64 Message-ID: <20090608.174450.250237255.hrs@allbsd.org> In-Reply-To: <yU9M2qm9rH%2BoeIVIgSzCrCakobk@j4OYE6OL8eALCd4BvSxIfwgoxSc> References: <sqWp8ZLqcJhvIOZAWr3MfqIXJ9k@XX1fo6zQUfC4h0jjRC6IBz3oNH4> <20090608.165325.225640915.hrs@allbsd.org> <yU9M2qm9rH%2BoeIVIgSzCrCakobk@j4OYE6OL8eALCd4BvSxIfwgoxSc>
next in thread | previous in thread | raw e-mail | index | archive | help
----Security_Multipart(Mon_Jun__8_17_44_50_2009_039)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Eygene Ryabinkin <rea-fbsd@codelabs.ru> wrote in <yU9M2qm9rH+oeIVIgSzCrCakobk@j4OYE6OL8eALCd4BvSxIfwgoxSc>: re> Do you intend to set sc->gif_options only for the case of failed re> copyin()? This looks a bit strange to me too, because re> 1. in this case 'options' will have undeterminate contents; re> 2. I thought that 'set options' should set options if it is re> permitted. re> Though there could be some logics behing this -- don't know, but re> may be the negation operator was lost before '(error = copyin(...))' -- re> this is most adequate description of check for GIF_FULLOPTS. Yea, you are right. '!' was missing at the head of the condition. The options should be updated when copyin() succeeds. Probably I need some sleep :| re> By the way, it will be great if new sysctls and their options will be re> documented somewhere, perhaps in the gif(4) itself. Okay, I think it is reasonable, too. I'll do. Thanks for the suggestion. -- Hiroki ----Security_Multipart(Mon_Jun__8_17_44_50_2009_039)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkosz4IACgkQTyzT2CeTzy3EUQCgznNEFpwCh6yCkbg+uZAs5m6q q2IAnij9WfyZTznMae7qDFC3CbXKcdvV =0tnq -----END PGP SIGNATURE----- ----Security_Multipart(Mon_Jun__8_17_44_50_2009_039)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090608.174450.250237255.hrs>