Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 15 Feb 2021 07:28:21 +0000
From:      bugzilla-noreply@freebsd.org
To:        fs@FreeBSD.org
Subject:   [Bug 253158] Panic: snapacct_ufs2: bad block - Non-suJ mksnap_ffs(8) crash
Message-ID:  <bug-253158-3630-LLji0AeIeo@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-253158-3630@https.bugs.freebsd.org/bugzilla/>
References:  <bug-253158-3630@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253158

--- Comment #41 from Konstantin Belousov <kib@FreeBSD.org> ---
(In reply to Kirk McKusick from comment #40)
There are actually two bugs, fixed by two patches.  One is the wrong size of
the vnode vm object.  BTW, I opted for additional vnode_pager_setsize()
instead of setting fs_size + fs_blksize in initial vnode_create_vobject(),
but I might reconsider this.  It is somewhat simpler to see consequences
of the fix/no fix when testing this variant of the patch alone.

Second bug is that page cache read path in vfs_vnops.c is confused when
uio_offset is past the end of file as recorded by vnode_pager_setsize().
It results in negative resid corrupting the state of the io request.

Either of changes should fix the problem, which I want to get confirmations
for.
But both bugs should be fixed.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-253158-3630-LLji0AeIeo>