Date: Sun, 13 Jan 2019 22:12:49 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 234622] [libc] getgrent() issue with large NIS groups Message-ID: <bug-234622-227-IiZm6PbsYk@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-234622-227@https.bugs.freebsd.org/bugzilla/> References: <bug-234622-227@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234622 Jilles Tjoelker <jilles@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jilles@FreeBSD.org Status|New |Open --- Comment #1 from Jilles Tjoelker <jilles@FreeBSD.org> --- This patch looks conceptually correct: if getgrent_r() returns ERANGE, it m= ust not advance the iterator. Apparently it is acceptable to call yp_first() or yp_next() with the same key multiple times. The code in FreeBSD head advances the iterator when ERANGE is returned, so = the excessively long group is discarded (but following groups will use a larger buffer). Potential issue in the patch: reading *errnop in if (*errnop =3D=3D ERANGE)= { without ensuring it is meaningful by checking rv =3D=3D NS_RETURN may not be correct. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-234622-227-IiZm6PbsYk>