Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 2 Jan 2026 10:27:33 +0200
From:      Matthias Fechner <mfechner@freebsd.org>
To:        Po-Chuan Hsieh <sunpoet@FreeBSD.org>, ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   Re: git: b38ff7a19b6c - main - devel/rubygem-json-schema-gitlab: Allow build with rubygem-bigdecimal 4.0.0+
Message-ID:  <b7fb7f71-4714-47ff-82c4-d22a0505bda8@freebsd.org>
In-Reply-To: <6953d50d.3f8e3.78676854@gitrepo.freebsd.org>

index | next in thread | previous in thread | raw e-mail

Dear Sunpoet,

Am 30.12.2025 um 15:35 schrieb Po-Chuan Hsieh:
> diff --git a/devel/rubygem-json-schema-gitlab/files/patch-gemspec b/devel/rubygem-json-schema-gitlab/files/patch-gemspec
> new file mode 100644
> index 000000000000..38fb16774913
> --- /dev/null
> +++ b/devel/rubygem-json-schema-gitlab/files/patch-gemspec
> @@ -0,0 +1,10 @@
> +--- json-schema.gemspec.orig	2025-12-29 04:13:58 UTC
> ++++ json-schema.gemspec
> +@@ -26,6 +26,6 @@ Gem::Specification.new do |s|
> +   s.add_development_dependency(%q<voxpupuli-rubocop>.freeze, ["~> 3.1.0".freeze])
> +   s.add_development_dependency(%q<webmock>.freeze, ["~> 3.23".freeze])
> +   s.add_runtime_dependency(%q<addressable>.freeze, ["~> 2.8".freeze])
> +-  s.add_runtime_dependency(%q<bigdecimal>.freeze, ["~> 3.1".freeze])
> ++  s.add_runtime_dependency(%q<bigdecimal>.freeze, [">= 3.1".freeze, "< 5".freeze])
> + end
> +
>
please stop modifying ports I maintain.
This changed upstream code which you have not tested.
This broke gitlab and if you had just done a build of gitlab you would 
have seen that.

If you add a new port to keep the version like it is, it is ok, but 
please stop doing these alterations without talking to me.
I'm normally very responsive and you get an answer normally in one day.

I reverted the commits already to unbreak gitlab and applied the right 
correction which is tested using runtime tests of gitlab.

Thanks
Matthias



home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b7fb7f71-4714-47ff-82c4-d22a0505bda8>