Date: Wed, 12 Dec 2012 23:22:50 -0800 From: Adrian Chadd <adrian@freebsd.org> To: Adrian Chadd <adrian@freebsd.org>, Andriy Gapon <avg@freebsd.org>, Alfred Perlstein <bright@mu.org>, John Baldwin <jhb@freebsd.org>, Alfred Perlstein <alfred@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r244112 - head/sys/kern Message-ID: <CAJ-VmomrZbgLJ21sBP0nsfTmNiqmB4E4YbSuxKeYKbEb4bftog@mail.gmail.com> In-Reply-To: <20121213071938.GA2074@itx> References: <201212110708.qBB78EWx025288@svn.freebsd.org> <201212121046.43706.jhb@freebsd.org> <CAJ-Vmo=U04GX%2BZyKuzXLwV%2BPpzU6_dm5BCmL=DWfsmhTVAR%2BsA@mail.gmail.com> <201212121658.49048.jhb@freebsd.org> <50C90567.8080406@FreeBSD.org> <50C909BD.9090709@mu.org> <50C97D94.1090603@FreeBSD.org> <CAJ-Vmo=Fh=UEcg8oXraU1C8_2T2pQW7SoSP=bpGCyGcSb6hmjQ@mail.gmail.com> <20121213071938.GA2074@itx>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12 December 2012 23:19, Navdeep Parhar <nparhar@gmail.com> wrote: > On Wed, Dec 12, 2012 at 11:07:58PM -0800, Adrian Chadd wrote: >> Andriy, >> >> If you are willing to enable INVARIANTS by default in GENERIC, right >> now, then I think we should remove Alfred's work. > > It's already enabled by default in GENERIC in the development branch > (aka head), which is exactly the right thing to do. Surely, you're not > advocating we enable it by default in any release branch? I'm sure at least one vendor out there would love to ship GENERIC + INVARIANTS minus the panic bit, so they get all of the invariants reporting and checking, but none of the panicing (which wouldn't occur if INVARIANTS wasn't compiled in.) WITNESS is still slow, but after I fixed a rather hilarious strlen() abuse in it, it actually started to be more useful to enable at runtime on my test equipment by default. Before I fixed that strlen() issue, I couldn't get anywhere near line rate ethernet/wifi throughput, so I didn't want to leave it on. Adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmomrZbgLJ21sBP0nsfTmNiqmB4E4YbSuxKeYKbEb4bftog>