Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 5 Feb 2008 18:21:10 +0000 (GMT)
From:      Robert Watson <rwatson@FreeBSD.org>
To:        John Birrell <jb@FreeBSD.org>
Cc:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   Re: PERFORCE change 134831 for review
Message-ID:  <20080205182026.D49855@fledge.watson.org>
In-Reply-To: <200802050929.m159Tc2s024644@repoman.freebsd.org>
References:  <200802050929.m159Tc2s024644@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 5 Feb 2008, John Birrell wrote:

> http://perforce.freebsd.org/chv.cgi?CH=134831
>
> Change 134831 by jb@jb_freebsd1 on 2008/02/05 09:29:08
>
> 	We define FOPEN_MAX as 20. What a joke.

I thought the comment was entertaining, apparently I'd never noticed that 
before:

/*
  * FOPEN_MAX is a minimum maximum, and is the number of streams that
  * stdio can provide without attempting to allocate further resources
  * (which could fail).  Do not use this for anything.
  */

Some piece of code clearly loses on this front..?

Robert N M Watson
Computer Laboratory
University of Cambridge

>
> Affected files ...
>
> .. //depot/projects/dtrace/src/contrib/one-true-awk/run.c#5 edit
>
> Differences ...
>
> ==== //depot/projects/dtrace/src/contrib/one-true-awk/run.c#5 (text+ko) ====
>
> @@ -63,6 +63,8 @@
> /* #ifndef RAND_MAX */
> /* #define RAND_MAX	32767 */	/* all that ansi guarantees */
> /* #endif */
> +#undef FOPEN_MAX
> +#define FOPEN_MAX	40
>
> jmp_buf env;
> extern	int	pairstack[];
>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080205182026.D49855>