Date: Fri, 3 Jan 2014 16:36:56 +0000 (UTC) From: Mateusz Guzik <mjg@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r260233 - head/sys/kern Message-ID: <201401031636.s03GauoU041016@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: mjg Date: Fri Jan 3 16:36:55 2014 New Revision: 260233 URL: http://svnweb.freebsd.org/changeset/base/260233 Log: Plug a memory leak in dup2 when both old and new fd have ioctl caps. Reviewed by: pjd MFC after: 3 days Modified: head/sys/kern/kern_descrip.c Modified: head/sys/kern/kern_descrip.c ============================================================================== --- head/sys/kern/kern_descrip.c Fri Jan 3 16:34:16 2014 (r260232) +++ head/sys/kern/kern_descrip.c Fri Jan 3 16:36:55 2014 (r260233) @@ -878,6 +878,7 @@ do_dup(struct thread *td, int flags, int /* * Duplicate the source descriptor. */ + filecaps_free(&newfde->fde_caps); *newfde = *oldfde; filecaps_copy(&oldfde->fde_caps, &newfde->fde_caps); if ((flags & DUP_CLOEXEC) != 0)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201401031636.s03GauoU041016>