Date: Tue, 08 Apr 2008 19:36:43 -0500 From: Nathan Whitehorn <nathanw@uchicago.edu> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: freebsd-ppc@freebsd.org Subject: Re: BMAC Ethernet Driver Message-ID: <47FC0F9B.6070902@uchicago.edu> In-Reply-To: <20080404061224.GB11845@FreeBSD.org> References: <C83E8810-B68B-49B5-A7F4-8B72A4FFFFDA@mac.com> <47F3D2BC.7060001@uchicago.edu> <47F422A0.9080907@uchicago.edu> <CB59240D-E385-4D4C-9372-E9D418502F61@mac.com> <EB224547-BCC9-4467-98E5-1D8EC0352349@mac.com> <Pine.GSO.4.62.0804022152590.20081@harper.uchicago.edu> <C1AB89FF-C466-46B0-BA83-2AD2989E73F9@mac.com> <47F4E007.90802@uchicago.edu> <3B02E59E-5399-40B6-9747-2F49200FD708@mac.com> <47F59C13.9030705@uchicago.edu> <20080404061224.GB11845@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Alexey Dokuchaev wrote:
> On Thu, Apr 03, 2008 at 10:10:11PM -0500, Nathan Whitehorn wrote:
>> --- macio.c 2007-12-20 18:23:22.000000000 -0600
>> +++ macio.c.multi 2008-04-03 20:00:23.562978813 -0500
>> @@ -179,27 +179,40 @@
>> static void
>> macio_add_intr(phandle_t devnode, struct macio_devinfo *dinfo)
>> {
>> - int intr;
>> + int *intr;
>> + int i, nintr;
>> + phandle_t iparent;
>> + int icells;
>
> From examples I see in man style(9), type and varname for local vars are
> seperated by space, not a tab.
Hmm. I was mostly just trying to match the style in the rest of macio.c.
Is it a better idea in this circumstance to match style(9) or the
existing code?
-Nathan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47FC0F9B.6070902>