Date: Tue, 6 Jun 2023 03:41:46 +0800 From: Po-Chuan Hsieh <sunpoet@freebsd.org> To: Matthias Andree <mandree@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 522d39ae76a1 - main - math/Imath: Fix GH_* usage Message-ID: <CAMHz58QT6itS2exoue_VemBFeHmfbLHuedda6cJ%2BpA1YWdXhHg@mail.gmail.com> In-Reply-To: <bb13c7be-3e23-59fa-8a29-14238896f64d@FreeBSD.org> References: <202306051901.355J1w9B078961@gitrepo.freebsd.org> <bb13c7be-3e23-59fa-8a29-14238896f64d@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Tue, Jun 6, 2023 at 3:07 AM Matthias Andree <mandree@freebsd.org> wrote: > Am 05.06.23 um 21:01 schrieb Po-Chuan Hsieh: > > The branch main has been updated by sunpoet: > > > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=522d39ae76a1d17440e529c80065250cedfd6224 > > > > commit 522d39ae76a1d17440e529c80065250cedfd6224 > > Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org> > > AuthorDate: 2023-06-05 18:46:16 +0000 > > Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org> > > CommitDate: 2023-06-05 18:49:13 +0000 > > > > math/Imath: Fix GH_* usage > > > > Approved by: portmgr (blanket) > > --- > > math/Imath/Makefile | 3 ++- > > math/Imath/distinfo | 6 +++--- > > 2 files changed, 5 insertions(+), 4 deletions(-) > > > > diff --git a/math/Imath/Makefile b/math/Imath/Makefile > > index 9fa973911789..c2d5eea7d856 100644 > > --- a/math/Imath/Makefile > > +++ b/math/Imath/Makefile > > @@ -2,6 +2,7 @@ > > > > PORTNAME= Imath > > PORTVERSION= 3.1.9 > > +DISTVERSIONPREFIX= v > > PORTREVISION= 0 > > CATEGORIES= math devel graphics > > > > @@ -14,7 +15,7 @@ LICENSE= BSD3CLAUSE > > USES= cmake compiler:c++14-lang pathfix pkgconfig > > > > USE_GITHUB= yes > > -GH_TUPLE= AcademySoftwareFoundation:Imath:v${PORTVERSION} > > +GH_ACCOUNT= AcademySoftwareFoundation > > USE_LDCONFIG= yes > > > > CMAKE_ARGS+= -DCMAKE_DEBUG_POSTFIX= \ > > Hi Po-Chuan, > > Care to explain what there was to "fix"? It wasn't broken. > > Regards, > Matthias > > -- > Matthias Andree > FreeBSD ports committer > Hello Matthias, GH_TUPLE is used for multiple distributions. In this case: - We use GH_{ACCOUNT,PROJECT,TAGNAME}. - GH_PROJECT is the default. - GH_TAGNAME is slightly different from PORTVERSION, therefore we use DISTVERSIONPREFIX instead. Regards, sunpoet [-- Attachment #2 --] <div dir="ltr"><div dir="ltr">On Tue, Jun 6, 2023 at 3:07 AM Matthias Andree <<a href="mailto:mandree@freebsd.org">mandree@freebsd.org</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Am 05.06.23 um 21:01 schrieb Po-Chuan Hsieh:<br> > The branch main has been updated by sunpoet:<br> > <br> > URL: <a href="https://cgit.FreeBSD.org/ports/commit/?id=522d39ae76a1d17440e529c80065250cedfd6224" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=522d39ae76a1d17440e529c80065250cedfd6224</a><br>; > <br> > commit 522d39ae76a1d17440e529c80065250cedfd6224<br> > Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org><br> > AuthorDate: 2023-06-05 18:46:16 +0000<br> > Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org><br> > CommitDate: 2023-06-05 18:49:13 +0000<br> > <br> > math/Imath: Fix GH_* usage<br> > <br> > Approved by: portmgr (blanket)<br> > ---<br> > math/Imath/Makefile | 3 ++-<br> > math/Imath/distinfo | 6 +++---<br> > 2 files changed, 5 insertions(+), 4 deletions(-)<br> > <br> > diff --git a/math/Imath/Makefile b/math/Imath/Makefile<br> > index 9fa973911789..c2d5eea7d856 100644<br> > --- a/math/Imath/Makefile<br> > +++ b/math/Imath/Makefile<br> > @@ -2,6 +2,7 @@<br> > <br> > PORTNAME= Imath<br> > PORTVERSION= 3.1.9<br> > +DISTVERSIONPREFIX= v<br> > PORTREVISION= 0<br> > CATEGORIES= math devel graphics<br> > <br> > @@ -14,7 +15,7 @@ LICENSE= BSD3CLAUSE<br> > USES= cmake compiler:c++14-lang pathfix pkgconfig<br> > <br> > USE_GITHUB= yes<br> > -GH_TUPLE= AcademySoftwareFoundation:Imath:v${PORTVERSION}<br> > +GH_ACCOUNT= AcademySoftwareFoundation<br> > USE_LDCONFIG= yes<br> > <br> > CMAKE_ARGS+= -DCMAKE_DEBUG_POSTFIX= \<br> <br> Hi Po-Chuan,<br> <br> Care to explain what there was to "fix"? It wasn't broken.<br> <br> Regards,<br> Matthias<br> <br> -- <br> Matthias Andree<br> FreeBSD ports committer <br></blockquote><div><br></div><div>Hello Matthias,</div><div><br></div><div>GH_TUPLE is used for multiple distributions.</div><div>In this case:<br></div><div>- We use GH_{ACCOUNT,PROJECT,TAGNAME}.</div><div>- GH_PROJECT is the default.</div><div>- GH_TAGNAME is slightly different from PORTVERSION, therefore we use DISTVERSIONPREFIX instead.</div><div><br></div><div>Regards,</div><div>sunpoet</div></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58QT6itS2exoue_VemBFeHmfbLHuedda6cJ%2BpA1YWdXhHg>