Date: Tue, 6 Jun 2023 03:41:46 +0800 From: Po-Chuan Hsieh <sunpoet@freebsd.org> To: Matthias Andree <mandree@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 522d39ae76a1 - main - math/Imath: Fix GH_* usage Message-ID: <CAMHz58QT6itS2exoue_VemBFeHmfbLHuedda6cJ%2BpA1YWdXhHg@mail.gmail.com> In-Reply-To: <bb13c7be-3e23-59fa-8a29-14238896f64d@FreeBSD.org> References: <202306051901.355J1w9B078961@gitrepo.freebsd.org> <bb13c7be-3e23-59fa-8a29-14238896f64d@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000f5901605fd6719ed Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jun 6, 2023 at 3:07=E2=80=AFAM Matthias Andree <mandree@freebsd.org= > wrote: > Am 05.06.23 um 21:01 schrieb Po-Chuan Hsieh: > > The branch main has been updated by sunpoet: > > > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=3D522d39ae76a1d17440e529c800652= 50cedfd6224 > > > > commit 522d39ae76a1d17440e529c80065250cedfd6224 > > Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org> > > AuthorDate: 2023-06-05 18:46:16 +0000 > > Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org> > > CommitDate: 2023-06-05 18:49:13 +0000 > > > > math/Imath: Fix GH_* usage > > > > Approved by: portmgr (blanket) > > --- > > math/Imath/Makefile | 3 ++- > > math/Imath/distinfo | 6 +++--- > > 2 files changed, 5 insertions(+), 4 deletions(-) > > > > diff --git a/math/Imath/Makefile b/math/Imath/Makefile > > index 9fa973911789..c2d5eea7d856 100644 > > --- a/math/Imath/Makefile > > +++ b/math/Imath/Makefile > > @@ -2,6 +2,7 @@ > > > > PORTNAME=3D Imath > > PORTVERSION=3D 3.1.9 > > +DISTVERSIONPREFIX=3D v > > PORTREVISION=3D 0 > > CATEGORIES=3D math devel graphics > > > > @@ -14,7 +15,7 @@ LICENSE=3D BSD3CLAUSE > > USES=3D cmake compiler:c++14-lang pathfix pkgconfig > > > > USE_GITHUB=3D yes > > -GH_TUPLE=3D AcademySoftwareFoundation:Imath:v${PORTVERSION} > > +GH_ACCOUNT=3D AcademySoftwareFoundation > > USE_LDCONFIG=3D yes > > > > CMAKE_ARGS+=3D -DCMAKE_DEBUG_POSTFIX=3D \ > > Hi Po-Chuan, > > Care to explain what there was to "fix"? It wasn't broken. > > Regards, > Matthias > > -- > Matthias Andree > FreeBSD ports committer > Hello Matthias, GH_TUPLE is used for multiple distributions. In this case: - We use GH_{ACCOUNT,PROJECT,TAGNAME}. - GH_PROJECT is the default. - GH_TAGNAME is slightly different from PORTVERSION, therefore we use DISTVERSIONPREFIX instead. Regards, sunpoet --000000000000f5901605fd6719ed Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr">On Tue, Jun 6, 2023 at 3:07=E2=80=AFAM Ma= tthias Andree <<a href=3D"mailto:mandree@freebsd.org">mandree@freebsd.or= g</a>> wrote:<br></div><div class=3D"gmail_quote"><blockquote class=3D"g= mail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204= ,204,204);padding-left:1ex">Am 05.06.23 um 21:01 schrieb Po-Chuan Hsieh:<br= > > The branch main has been updated by sunpoet:<br> > <br> > URL: <a href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3D522d39ae76= a1d17440e529c80065250cedfd6224" rel=3D"noreferrer" target=3D"_blank">https:= //cgit.FreeBSD.org/ports/commit/?id=3D522d39ae76a1d17440e529c80065250cedfd6= 224</a><br> > <br> > commit 522d39ae76a1d17440e529c80065250cedfd6224<br> > Author:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@FreeBSD.org><= br> > AuthorDate: 2023-06-05 18:46:16 +0000<br> > Commit:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@FreeBSD.org><= br> > CommitDate: 2023-06-05 18:49:13 +0000<br> > <br> >=C2=A0 =C2=A0 =C2=A0 math/Imath: Fix GH_* usage<br> >=C2=A0 =C2=A0 =C2=A0 <br> >=C2=A0 =C2=A0 =C2=A0 Approved by:=C2=A0 =C2=A0 portmgr (blanket)<br> > ---<br> >=C2=A0 =C2=A0math/Imath/Makefile | 3 ++-<br> >=C2=A0 =C2=A0math/Imath/distinfo | 6 +++---<br> >=C2=A0 =C2=A02 files changed, 5 insertions(+), 4 deletions(-)<br> > <br> > diff --git a/math/Imath/Makefile b/math/Imath/Makefile<br> > index 9fa973911789..c2d5eea7d856 100644<br> > --- a/math/Imath/Makefile<br> > +++ b/math/Imath/Makefile<br> > @@ -2,6 +2,7 @@<br> >=C2=A0 =C2=A0<br> >=C2=A0 =C2=A0PORTNAME=3D=C2=A0 =C2=A0Imath<br> >=C2=A0 =C2=A0PORTVERSION=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 3.1.9<br> > +DISTVERSIONPREFIX=3D=C2=A0 =C2=A0v<br> >=C2=A0 =C2=A0PORTREVISION=3D=C2=A0 =C2=A0 =C2=A0 =C2=A00<br> >=C2=A0 =C2=A0CATEGORIES=3D math devel graphics<br> >=C2=A0 =C2=A0<br> > @@ -14,7 +15,7 @@ LICENSE=3D=C2=A0 =C2=A0 BSD3CLAUSE<br> >=C2=A0 =C2=A0USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0cmake compiler:c++14-lang pathfix pkgconfig<br> >=C2=A0 =C2=A0<br> >=C2=A0 =C2=A0USE_GITHUB=3D yes<br> > -GH_TUPLE=3D=C2=A0 =C2=A0 AcademySoftwareFoundation:Imath:v${PORTVERSI= ON}<br> > +GH_ACCOUNT=3D=C2=A0 AcademySoftwareFoundation<br> >=C2=A0 =C2=A0USE_LDCONFIG=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0yes<br> >=C2=A0 =C2=A0<br> >=C2=A0 =C2=A0CMAKE_ARGS+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 -DCMAKE_DEBUG_PO= STFIX=3D \<br> <br> Hi Po-Chuan,<br> <br> Care to explain what there was to "fix"? It wasn't broken.<br= > <br> Regards,<br> Matthias<br> <br> -- <br> Matthias Andree<br> FreeBSD ports committer=C2=A0<br></blockquote><div><br></div><div>Hello Mat= thias,</div><div><br></div><div>GH_TUPLE is used for multiple distributions= .</div><div>In this case:<br></div><div>- We use GH_{ACCOUNT,PROJECT,TAGNAM= E}.</div><div>- GH_PROJECT is the default.</div><div>- GH_TAGNAME is slight= ly different from PORTVERSION, therefore we use=C2=A0DISTVERSIONPREFIX inst= ead.</div><div><br></div><div>Regards,</div><div>sunpoet</div></div></div> --000000000000f5901605fd6719ed--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58QT6itS2exoue_VemBFeHmfbLHuedda6cJ%2BpA1YWdXhHg>