Date: Mon, 1 Jun 2009 17:09:20 -0700 From: Kip Macy <kmacy@freebsd.org> To: "M. Warner Losh" <imp@bsdimp.com> Cc: arm@freebsd.org Subject: Re: svn commit: r193282 - stable/7/sys/libkern Message-ID: <3c1674c90906011709g757a3abds75a0cde8927bc46b@mail.gmail.com> In-Reply-To: <20090601.175146.255408209.imp@bsdimp.com> References: <200906012209.n51M9gTU094161@svn.freebsd.org> <20090601.175146.255408209.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
No, this is a band-aid for a mistake I made in the ZFS MFC. I had hoped to avoid updating all the files.<arch>, but I will do that if need be. Cheers, Kip On Mon, Jun 1, 2009 at 4:51 PM, M. Warner Losh <imp@bsdimp.com> wrote: > In message: <200906012209.n51M9gTU094161@svn.freebsd.org> > =A0 =A0 =A0 =A0 =A0 =A0Kip Macy <kmacy@FreeBSD.org> writes: > : Author: kmacy > : Date: Mon Jun =A01 22:09:42 2009 > : New Revision: 193282 > : URL: http://svn.freebsd.org/changeset/base/193282 > : > : Log: > : =A0 memmove is defined in support.S on arm - don't compile in > : > : Modified: > : =A0 stable/7/sys/libkern/memmove.c > : > : Modified: stable/7/sys/libkern/memmove.c > : =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > : --- stable/7/sys/libkern/memmove.c =A0 =A0Mon Jun =A01 22:05:08 2009 = =A0 =A0 =A0 =A0(r193281) > : +++ stable/7/sys/libkern/memmove.c =A0 =A0Mon Jun =A01 22:09:42 2009 = =A0 =A0 =A0 =A0(r193282) > : @@ -29,6 +29,7 @@ __FBSDID("$FreeBSD$"); > : > : =A0#include <sys/libkern.h> > : > : +#if !defined(__arm__) > : =A0void * > : =A0memmove(void *dest, const void *src, size_t n) > : =A0{ > : @@ -36,3 +37,4 @@ memmove(void *dest, const void *src, siz > : =A0 =A0 =A0 bcopy(src, dest, n); > : =A0 =A0 =A0 return (dest); > : =A0} > : +#endif > > Ummm, usually we don't bother to even include the .c file in cases > like this... =A0Is it this way in -head? > > > Warner > --=20 When bad men combine, the good must associate; else they will fall one by one, an unpitied sacrifice in a contemptible struggle. Edmund Burke
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3c1674c90906011709g757a3abds75a0cde8927bc46b>