Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 4 Jun 2025 01:51:14 GMT
From:      Kyle Evans <kevans@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 969f6380eb66 - main - kdump: nicer printing of kill(2) PID argument
Message-ID:  <202506040151.5541pESm016476@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by kevans:

URL: https://cgit.FreeBSD.org/src/commit/?id=969f6380eb66f809eed3e5c38b6021824a4cc2bf

commit 969f6380eb66f809eed3e5c38b6021824a4cc2bf
Author:     Kyle Evans <kevans@FreeBSD.org>
AuthorDate: 2025-06-04 01:51:06 +0000
Commit:     Kyle Evans <kevans@FreeBSD.org>
CommitDate: 2025-06-04 01:51:06 +0000

    kdump: nicer printing of kill(2) PID argument
    
    Similar to wait*(), kill(2) operates on a pid that currently gets output
    as hex.  Output it in decimal to make it a little easier to eyeball the
    pid we're signalling.
    
    Reviewed by:    markj
    Differential Revision:  https://reviews.freebsd.org/D50508
---
 usr.bin/kdump/kdump.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/usr.bin/kdump/kdump.c b/usr.bin/kdump/kdump.c
index ff32dd418f24..86df45acdf05 100644
--- a/usr.bin/kdump/kdump.c
+++ b/usr.bin/kdump/kdump.c
@@ -1028,7 +1028,8 @@ ktrsyscall_freebsd(struct ktr_syscall *ktr, register_t **resip,
 				narg--;
 				break;
 			case SYS_kill:
-				print_number(ip, narg, c);
+				*ip = (pid_t)*ip;
+				print_decimal_number(ip, narg, c);
 				putchar(',');
 				print_signal(*ip);
 				ip++;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202506040151.5541pESm016476>