Date: Sat, 19 Oct 2024 12:19:52 -0600 From: Warner Losh <imp@bsdimp.com> To: Rebecca Cran <rebecca@bsdio.com> Cc: Current FreeBSD <freebsd-current@freebsd.org>, Emmanuel Vadot <manu@freebsd.org> Subject: Re: loader.efi: "Malformed line (27)" error apparently due to recent splash config entry Message-ID: <CANCZdfrKJ%2Bp6kBA4BJHqXzMUH3vo0KHqGqF5Cd=64p2BvxMZ-g@mail.gmail.com> In-Reply-To: <52524135-d232-460a-9961-1fbc4463f6ba@bsdio.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Hey Rebecca I've uploaded this differential https://reviews.freebsd.org/D47201 which should fix it. We should allow " in # comments, but at the moment we don't. We should also fix the parser to allow it. Since stabilization week is coming up, I'd like to rush this in, if it works. Warner On Sat, Oct 19, 2024 at 9:45 AM Rebecca Cran <rebecca@bsdio.com> wrote: > I just updated one of my systems (an AArch64 ADLINK Ampere Altra Dev > Kit) to the latest -CURRENT and copied the latest /boot/loader.efi into > /boot/efi/efi/freebsd/loader.efi and /boot/efi/efi/boot/bootaa64.efi and > noticed a new message during boot, apparently introduced in this commit? > > > commit 7df3e400ea68722b6263cd71937e43a98585eeda > Author: Emmanuel Vadot <manu@FreeBSD.org> > Date: Mon Oct 14 11:25:57 2024 +0200 > > loader: default: Add a default splash screen > > Setting boot_mute="YES" currently use the in-kernel black and white > logo. > Instead default to the color png one. > > Sponsored by: Beckhoff Automation GmbH & Co. KGSetting currdev to > zfs:zroot/ROOT/default: > > > The messages are: > > Loading /boot/defaults/loader.conf > Loading /boot/defaults/loader.conf > Malformed line (27): > 'splash="/boot/images/freebsd-logo-rev.png" # Set > boot_mute="YES" to load it' > Failed to parse config: '/boot/defaults/loader.conf' > Loading /boot/device.hints > > -- > Rebecca Cran > > > [-- Attachment #2 --] <div dir="ltr"><div>Hey Rebecca</div><div><br></div><div>I've uploaded this differential</div><div><br></div><a href="https://reviews.freebsd.org/D47201">https://reviews.freebsd.org/D47201</a><br><div><br></div><div>which should fix it. We should allow " in # comments, but at the moment we don't. We should also fix the</div><div>parser to allow it. Since stabilization week is coming up, I'd like to rush this in, if it works.</div><div><br></div><div>Warner</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Oct 19, 2024 at 9:45 AM Rebecca Cran <<a href="mailto:rebecca@bsdio.com">rebecca@bsdio.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I just updated one of my systems (an AArch64 ADLINK Ampere Altra Dev <br> Kit) to the latest -CURRENT and copied the latest /boot/loader.efi into <br> /boot/efi/efi/freebsd/loader.efi and /boot/efi/efi/boot/bootaa64.efi and <br> noticed a new message during boot, apparently introduced in this commit?<br> <br> <br> commit 7df3e400ea68722b6263cd71937e43a98585eeda<br> Author: Emmanuel Vadot <manu@FreeBSD.org><br> Date: Mon Oct 14 11:25:57 2024 +0200<br> <br> loader: default: Add a default splash screen<br> <br> Setting boot_mute="YES" currently use the in-kernel black and white <br> logo.<br> Instead default to the color png one.<br> <br> Sponsored by: Beckhoff Automation GmbH & Co. KGSetting currdev to <br> zfs:zroot/ROOT/default:<br> <br> <br> The messages are:<br> <br> Loading /boot/defaults/loader.conf<br> Loading /boot/defaults/loader.conf<br> Malformed line (27):<br> 'splash="/boot/images/freebsd-logo-rev.png" # Set <br> boot_mute="YES" to load it'<br> Failed to parse config: '/boot/defaults/loader.conf'<br> Loading /boot/device.hints<br> <br> -- <br> Rebecca Cran<br> <br> <br> </blockquote></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrKJ%2Bp6kBA4BJHqXzMUH3vo0KHqGqF5Cd=64p2BvxMZ-g>