Date: Sun, 5 Jul 2020 11:36:17 +0300 From: Pavel Timofeev <timp87@gmail.com> To: Hiroki Sato <hrs@freebsd.org> Cc: 0mp@freebsd.org, ports-list freebsd <freebsd-ports@freebsd.org>, manu@freebsd.org, walter.von.entferndt@posteo.net Subject: Re: set_rcvar() function use? Message-ID: <CAAoTqftZzbcZgwzEYu-AyjPT5ZqTtmg8RLb6KB7-bj_J%2BOa6DA@mail.gmail.com> In-Reply-To: <20200704.140946.1661194655626577558.hrs@FreeBSD.org> References: <CAAoTqfss_-=N4EGd=XKDA%2BtzqvK5YZ7Ci6QJZvvip2xc64fYrw@mail.gmail.com> <20200703.035403.856368268140192104.hrs@FreeBSD.org> <34921b6e-ce3a-13e4-0cc1-3ca47b5a9cef@FreeBSD.org> <20200704.140946.1661194655626577558.hrs@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
=D1=81=D0=B1, 4 =D0=B8=D1=8E=D0=BB. 2020 =D0=B3. =D0=B2 08:11, Hiroki Sato = <hrs@freebsd.org>: > Mateusz Piotrowski <0mp@FreeBSD.org> wrote > in <34921b6e-ce3a-13e4-0cc1-3ca47b5a9cef@FreeBSD.org>: > > 0m> > I am planning to revisit the multi-instance support shortly becaus= e > I > 0m> > am using it for a long time and I think it is useful. While I did > 0m> > not receive a strong objection to it so far, it is also true that > 0m> > adopting the set_rcvar() style was not discussed properly. I woul= d > 0m> > like more feedback before moving forward. > 0m> > 0m> AFAIR, manu@ was concerned at some point that using set_rcvar() > extensively > 0m> might result in slowdowns on embedded systems. > > A discussion in the past about the performance was an additional > fork(2) when using set_rcvar() for rc_var=3D`set_rcvar`. The use case > of the resurrected one is "set_rcvar A B" as a replacement of "A=3DB", > and it does not involve a subshell. > > I agree that the performance perspective should also be discussed, > though. The current rc.subr and network.subr already have more > expensive operations, so we might want to gather profiling > information. > > Thanks a lot for the answers! It's great that the only existed concern is not a problem anymore for the resurrected "set_rcvar A B" form. IMO features like setting variable description and ability to "ask" rc script what variables/options are available are really great even without multi-instance support.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAAoTqftZzbcZgwzEYu-AyjPT5ZqTtmg8RLb6KB7-bj_J%2BOa6DA>