Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 4 Nov 2004 11:10:25 +0000
From:      Ceri Davies <ceri@submonkey.net>
To:        "David E. O'Brien" <obrien@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/usr.sbin/sysinstall config.c
Message-ID:  <20041104111025.GG57641@submonkey.net>
In-Reply-To: <200411040128.iA41ShNQ055582@repoman.freebsd.org>
References:  <200411040128.iA41ShNQ055582@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--kWb2NB+iM6KO7H8g
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 04, 2004 at 01:28:43AM +0000, David E. O'Brien wrote:
> obrien      2004-11-04 01:28:43 UTC
>=20
>   FreeBSD src repository
>=20
>   Modified files:
>     usr.sbin/sysinstall  config.c=20
>   Log:
>   Stop listening to bug reports with wrong solutions and commit a fix to =
the '
>   problem I know will work.

This line now gets written to /tmp/exports:

> | @@ -876,7 +876,7 @@ configNFSServer(dialogMenuItem *self)
> |  	    vsystem("echo '#/a      -maproot=3D0  -network 10.0.1.0 -mask 255=
=2E255.248.0' >> /etc/exports");
> |  	    vsystem("echo '#' >> /etc/exports");
> |  	    vsystem("echo '# You should replace these lines with your actual =
exported filesystems.' >> /etc/exports");
> | -	    vsystem("echo '# Note that BSD\'s export syntax is \"host-centric=
\" vs. Sun\'s \"FS-centric\" one.' >> /etc/exports");
> | +	    vsystem("echo \"# Note that BSD's export syntax is 'host-centric'=
 vs. Sun's 'FS-centric' one.\" >> /tmp/exports");

Also, wouldn't it just be easier to open() /etc/exports and write to it
that way?  I understand that this isn't how this is done anywhere else
in sysinstall, but why not?

Ceri
--=20

--kWb2NB+iM6KO7H8g
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (FreeBSD)

iD8DBQFBig4hocfcwTS3JF8RAvvHAKCnjpd8pN4cgb6lRLbrxTIiO6Zg1gCgmrKu
G5wC93y6f65TEYdYfeDY5vs=
=airX
-----END PGP SIGNATURE-----

--kWb2NB+iM6KO7H8g--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041104111025.GG57641>