Date: Sun, 20 Jul 2014 22:49:33 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 191953] [vfs] [patch] better KASSERT msg in _vn_lock() Message-ID: <bug-191953-8-Tj66UaVpiS@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-191953-8@https.bugs.freebsd.org/bugzilla/> References: <bug-191953-8@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191953 Hiren Panchasara <hiren@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hiren@FreeBSD.org --- Comment #2 from Hiren Panchasara <hiren@FreeBSD.org> --- Thanks for your submission. I am assuming that the comment is correct but the KASSERT itself is wrong. We probably want to fail when either of the events fail. I am proposing following change to KASSERT. While here, fixing 80-column wrapping. - KASSERT((flags & LK_RETRY) == 0 || error == 0, - ("LK_RETRY set with incompatible flags (0x%x) or an error occured (%d)", - flags, error)); + KASSERT((flags & LK_RETRY) == 0 && error == 0, + ("LK_RETRY set with incompatible flags (0x%x) or an error " + "occured (%d)", flags, error)); -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-191953-8-Tj66UaVpiS>