Date: Sat, 28 Jan 2017 12:17:48 -0800 From: Ngie Cooper <yaneurabeya@gmail.com> To: Allan Jude <allanjude@freebsd.org> Cc: Warner Losh <imp@bsdimp.com>, Julian Elischer <julian@freebsd.org>, Toomas Soome <tsoome@me.com>, FreeBSD Current <current@freebsd.org> Subject: Re: gptzfsboot grew a lot after skein support was added; need knob to control bloat Message-ID: <CAGHfRMDzXhauXi7r=CSih_moH0Po2K2=MGrz8sK1xmDqifPEiA@mail.gmail.com> In-Reply-To: <CAGHfRMB33A8%2B0tHQM=TUP6c-q5iTiQyRzNU9brcuQWh8hJcPwg@mail.gmail.com> References: <A33154F2-70E1-4047-8496-7D4D85CFF292@gmail.com> <EF719374-BF9D-44EF-9F45-53B2B506047C@me.com> <CANCZdfrzOr3YdbAKRrwUXsFDhdQ3hErf1vbYSG7MdpV_m%2B=YRQ@mail.gmail.com> <EB309E42-BEA6-49DF-BF34-172076851891@gmail.com> <f251f193-0fcd-cb2d-0fff-c443c4ca49d6@freebsd.org> <CANCZdfqdZumJvRcHGmZR_9s-ULFWsvp7h91H39o4nPgyqPBooA@mail.gmail.com> <CAGHfRMBQNSgAUGZfZQ7gD-OU4q-5sW54bdCS%2B-9_3k1ZbLu-kw@mail.gmail.com> <cea48de5-447c-bd84-c6b0-2803d00f50f9@freebsd.org> <CAGHfRMAR4XbJCae5K_XXYYzFrFjhfUVGscZ4gLhsALWouT26aw@mail.gmail.com> <373376e9-2a30-3cb4-ec60-b5b5f27de596@freebsd.org> <CAGHfRMB33A8%2B0tHQM=TUP6c-q5iTiQyRzNU9brcuQWh8hJcPwg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jan 28, 2017 at 11:22 AM, Ngie Cooper <yaneurabeya@gmail.com> wrote:
>> What created a partition that small?
>
> Me.
>
> gpart up until last summer said that users should create 44kB
> freebsd-boot partitions -- des@ corrected that in r303289:
>
> -This example uses 88 blocks (44 kB) so the next partition will be
> -aligned on a 64 kB boundary without the need to specify an explicit
> -offset or alignment.
> -The boot partition itself is aligned on a 4 kB boundary.
> +We create a 472-block (236 kB) boot partition at offset 40, which is
> +the size of the partition table (34 blocks or 17 kB) rounded up to the
> +nearest 4 kB boundary.
> .Bd -literal -offset indent
> -/sbin/gpart add -b 40 -s 88 -t freebsd-boot ada0
> +/sbin/gpart add -b 40 -s 472 -t freebsd-boot ada0
After some creative hacking... tada!
# find /usr/obj/usr/src/sys/boot/ -type f -name \*zfsboot -exec ls -l {} \;
-rw-r--r-- 1 root wheel 131584 Jan 28 12:07
/usr/obj/usr/src/sys/boot/i386/zfsboot/zfsboot
-rw-r--r-- 1 root wheel 47527 Jan 28 12:07
/usr/obj/usr/src/sys/boot/i386/gptzfsboot/gptzfsboot
-- wait, why is the size of zfsboot vs gptzfsboot so different? Oh,
r304321 added that as `BOOT2SIZE`. Still, it seems a bit silly to only
increase the size of one bootloader and not the other 4 instances of
the bootloader :/. I don't understand the point in the size
restriction 100%, but I'll leave it be.
Patch will be available sometime next week if my testing goes well.
Cheers,
-Ngie
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGHfRMDzXhauXi7r=CSih_moH0Po2K2=MGrz8sK1xmDqifPEiA>