Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 3 Jul 2018 15:56:22 +0000 (UTC)
From:      Sean Bruno <sbruno@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r335894 - head/sys/dev/ata/chipsets
Message-ID:  <201807031556.w63FuMHl042728@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: sbruno
Date: Tue Jul  3 15:56:22 2018
New Revision: 335894
URL: https://svnweb.freebsd.org/changeset/base/335894

Log:
  Reset indentation of this flag. No functional change intended.
  Found with gcc.
  
  sys/dev/ata/chipsets/ata-siliconimage.c: In function 'ata_cmd_ch_attach':
  sys/dev/ata/chipsets/ata-siliconimage.c:187:5:
   warning: this 'if' clause does not guard... [-Wmisleading-indentation]
       if (ctlr->chip->cfg2 & SII_INTR)
       ^~
  sys/dev/ata/chipsets/ata-siliconimage.c:190:2:
  note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
    ch->flags |= ATA_NO_ATAPI_DMA;

Modified:
  head/sys/dev/ata/chipsets/ata-siliconimage.c

Modified: head/sys/dev/ata/chipsets/ata-siliconimage.c
==============================================================================
--- head/sys/dev/ata/chipsets/ata-siliconimage.c	Tue Jul  3 15:48:34 2018	(r335893)
+++ head/sys/dev/ata/chipsets/ata-siliconimage.c	Tue Jul  3 15:56:22 2018	(r335894)
@@ -187,7 +187,7 @@ ata_cmd_ch_attach(device_t dev)
     if (ctlr->chip->cfg2 & SII_INTR)
 	ch->hw.status = ata_cmd_status;
 
-	ch->flags |= ATA_NO_ATAPI_DMA;
+    ch->flags |= ATA_NO_ATAPI_DMA;
 
     return 0;
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201807031556.w63FuMHl042728>