Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 4 Apr 2017 10:14:28 -0700
From:      "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
To:        Conrad Meyer <cem@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r316492 - in head/usr.bin/grep: . regex
Message-ID:  <4D675D2F-7D6F-4AF2-AE10-5DF19D4158D0@gmail.com>
In-Reply-To: <201704041608.v34G8qSo055328@repo.freebsd.org>
References:  <201704041608.v34G8qSo055328@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

[-- Attachment #1 --]

> On Apr 4, 2017, at 09:08, Conrad Meyer <cem@FreeBSD.org> wrote:
> 
> Author: cem
> Date: Tue Apr  4 16:08:51 2017
> New Revision: 316492
> URL: https://svnweb.freebsd.org/changeset/base/316492
> 
> Log:
>  bsdgrep(1): Rip out "xmalloc" bits
> 
>  xmalloc was a debug malloc implementation, but the x{malloc,calloc,free}
>  functions default to calling the malloc(3) equivalents.
> 
>  Instead of relying on this malloc shim, we can devise better ways to debug
>  malloc issues that aren't misleading upon initial inspection.  (I.e., using
>  jemalloc's various built-in debugging capabilities.)
> 
>  Submitted by:	Kyle Evans <kevans91 at ksu.edu>
>  Reviewed by:	emaste, cem
>  Differential Revision:	https://reviews.freebsd.org/D10269
> 
> Deleted:
>  head/usr.bin/grep/regex/xmalloc.c
>  head/usr.bin/grep/regex/xmalloc.h
> Modified:
>  head/usr.bin/grep/Makefile
>  head/usr.bin/grep/regex/fastmatch.c
>  head/usr.bin/grep/regex/tre-compile.c
>  head/usr.bin/grep/regex/tre-fastmatch.c

Where did xmalloc.c originate from? I can’t find any references to it in OpenBSD’s grep implementation (I’m pretty sure this copy of grep started there).
Thanks,
-Ngie

[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org

iQIcBAEBCgAGBQJY49R0AAoJEPWDqSZpMIYVxoQP/0EBXD4HmhucR/qKXw/VKGcw
gFLsU0PwPekHIdM1CaRN0nMYtBKoJK7kwjKsh+iE8pAX6qlhLsg0IchesnMDDhPY
2N8jccFSlYU8tdQSKc6XOgXprKhnTucNovWlOqOztvPy72EJiT51QzcNq4Q27AlN
evKpen9LmK0JkuKc7gerj4cFQn8m0QLl/ytQMCHQsqREV2T1h+MMtgvd+HH8IVZ9
XwLGijuaBCJxC77+tOeKOEegwb210qknx/P4yO74vPIrCU0KkDNDA7QkJ9enugCJ
2bdB3lo+Fn0ZTSC/lxClTXqRrFo/JU0LM64OmtyLZ69etEZpKLpRq7Qvp5pvsSb4
rUgEF8YXyuyCHLfDY4NcQCH7R8QKGbWh2w31p6EwqVQWdZKIkTnRsiUop2R1OQGn
EJXWISKcCIBsvZeUNHQhtkGS4cMDtcjGKbnXkKyaR5CGeAhm+jfrpL/I2VpK1mx9
1zmiIcgUxGrbru09URo4I2AW/LY4d9wJWiqebRkahX9RyVI0MeNugnv5owdIOqGZ
nkJzxEq1O6oO4bvt7nrwlowbQeqkcEg5NIgxLMJIJuHYi3Hpypr9I+43XgQ8Irrg
eNqWpcijDXjTuo18YTpY7Sep2Xjzu0CtOoLUpWxC8BLS8fKnoRCezdMVFHcm5pcP
BAxRpAilZin4OezaMN9z
=jJ2J
-----END PGP SIGNATURE-----

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4D675D2F-7D6F-4AF2-AE10-5DF19D4158D0>