Date: Mon, 20 Nov 2017 18:46:34 -0700 From: Warner Losh <imp@bsdimp.com> To: Alan Somers <asomers@freebsd.org> Cc: Ed Maste <emaste@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r326039 - in head: etc/mtree usr.bin/head usr.bin/head/tests Message-ID: <CANCZdfqhyThKK=S6bKPN3us0ttcecY_53SCp4tGqTQH3Wwhf4A@mail.gmail.com> In-Reply-To: <CANCZdfrrp6kCZO_43pauYSRWjdKUsiL6B-v3fmycZevCb0do0A@mail.gmail.com> References: <201711202255.vAKMt2nP014201@repo.freebsd.org> <CAPyFy2BDB5dVF_hURt9Xs4U4PzHW8KoL=6%2BEf0WGJgTxQSVaPw@mail.gmail.com> <CAOtMX2iot8LRW1VqN5UNAaF4p59hdMwN7NJVRqXwbk5mm1f8-g@mail.gmail.com> <CANCZdfrrp6kCZO_43pauYSRWjdKUsiL6B-v3fmycZevCb0do0A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Nov 20, 2017 6:36 PM, "Alan Somers" <asomers@freebsd.org> wrote: On Mon, Nov 20, 2017 at 6:32 PM, Ed Maste <emaste@freebsd.org> wrote: > On 20 November 2017 at 17:55, Alan Somers <asomers@freebsd.org> wrote: >> Author: asomers >> Date: Mon Nov 20 22:55:02 2017 >> New Revision: 326039 >> URL: https://svnweb.freebsd.org/changeset/base/326039 >> >> Log: >> Add ATF tests for head(1) >> >> Submitted by: Fred Schlecter <https://github.com/fjs-github>; >> Reviewed by: asomers, jilles >> MFC after: 3 weeks >> Differential Revision: https://github.com/freebsd/ freebsd/pull/127 > > It's certainly a good idea to capture the source of changes that come > in via GitHub pull requests, but the 'Differential Revision' field is > specifically for reviews in our own hosted Phabricator instance. > > We don't have an officially established metadata field for changes > that come in via pull requests at the moment. I'd suggest we just go > with: > Pull request: https://github.com/freebsd/freebsd/pull/127 Are there any automated tools that care about the "Differential Revision" field? If so, they should be able to tell the difference between GitHub revisions and Phabricator revisions based on the URL. Using "Differential Revision" instead of "Pull request" is handy, because it's part of the standard commit template, which encourages consistency. We should add Pull Request: to the template. Differential Revision really is a specific thing for phabricator... Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfqhyThKK=S6bKPN3us0ttcecY_53SCp4tGqTQH3Wwhf4A>