Date: Thu, 4 Apr 2019 00:09:48 -0400 From: Phil Shafer <phil@juniper.net> To: Enji Cooper <yaneurabeya@gmail.com> Cc: Phil Shafer <phil@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, <svn-src-vendor@freebsd.org> Subject: Re: svn commit: r345860 - vendor/Juniper/libxo Message-ID: <2C38A6BB-9915-4BC1-88BD-EA6919FFFED5@juniper.net> In-Reply-To: <D083E2F3-E779-484A-A6D9-F4F4D8425A18@gmail.com> References: <201904032230.x33MUKRn029430@repo.freebsd.org> <D083E2F3-E779-484A-A6D9-F4F4D8425A18@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3 Apr 2019, at 23:07, Enji Cooper wrote:
> I could be wrong, but I’m guessing `GMAKE` needs to be replaced with
> `MAKE`..?
GMAKE is set inside the import script, where MAKE=gmake is for
configure.
> Also, why does a configure script need gmake? It seems like the
> snippets that make libxo should be made more portable with autoconf,
> if that’s the case.
configure uses gmake to build dependencies, but assumes "make" means
gmake (${MAKE-make}). When it finds real make instead it will complain:
Something went wrong bootstrapping makefile fragments
for automatic dependency tracking. Try re-running configure with
the
'--disable-dependency-tracking' option to at least be able to build
the package (albeit without support for automatic dependency
tracking).
See `config.log' for more details
The autoconf tools are increasingly linux-centric, so the MAKE=gmake is
needed for BSD platforms. Longer term, I will probably move away from
them, as more problems are appearing. For example, libtool is not
naming test executables "lt-text_01.test", which makes the output of
"make test" different under linux (since error messages include argv[0].
So now I need to call xo_program() to explicitly set the name.
Eventually cost(work-arounds) > cost(requiring-bmake).
Thanks,
Phil
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2C38A6BB-9915-4BC1-88BD-EA6919FFFED5>