Date: Tue, 31 Jul 2012 20:29:55 -0400 From: Ben Kaduk <minimarmot@gmail.com> To: Adrian Chadd <adrian@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r238962 - head/sys/dev/ath/ath_rate/sample Message-ID: <CAK2BMK7ZBGupTX7f74hQCfGT1s4_eyHLSBRSezZc%2BRU5Dvj3nQ@mail.gmail.com> In-Reply-To: <201208010018.q710I2Uh088989@svn.freebsd.org> References: <201208010018.q710I2Uh088989@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 31, 2012 at 8:18 PM, Adrian Chadd <adrian@freebsd.org> wrote: > --- head/sys/dev/ath/ath_rate/sample/sample.c Tue Jul 31 23:54:15 2012 (r238961) > +++ head/sys/dev/ath/ath_rate/sample/sample.c Wed Aug 1 00:18:02 2012 (r238962) > @@ -504,7 +504,7 @@ ath_rate_findrate(struct ath_softc *sc, > > mrr = sc->sc_mrretry; > /* XXX check HT protmode too */ > - if (mrr && (ic->ic_flags & IEEE80211_F_USEPROT) && !sc->sc_mrrprot) > + if (mrr && (ic->ic_flags & IEEE80211_F_USEPROT && !sc->sc_mrrprot)) > mrr = 0; > > best_rix = pick_best_rate(an, rt, size_bin, !mrr); Logical '&&' evaluates left-to-right already, so I do not see that the current parentheses are needed? -Ben
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAK2BMK7ZBGupTX7f74hQCfGT1s4_eyHLSBRSezZc%2BRU5Dvj3nQ>