Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 10 May 2005 23:43:41 -0400
From:      Mikhail Teterin <mi+mx@aldan.algebra.com>
To:        Daniel Eischen <deischen@freebsd.org>
Cc:        re@freebsd.org
Subject:   Re: PTHREAD_INVARIANTS in 5.x
Message-ID:  <200505102343.42387@Misha>
In-Reply-To: <Pine.GSO.4.43.0505102105280.4305-100000@sea.ntplx.net>
References:  <Pine.GSO.4.43.0505102105280.4305-100000@sea.ntplx.net>

next in thread | previous in thread | raw e-mail | index | archive | help
= > As we were counting down to 5.3-RELEASE, I noticed, that all
= > threading libraries still compile with PTHREAD_INVARIANTS. My
= > suggestion to have this = > fixed was shutdown as not enough time
= > was left for testing the 5.3.

= > Can we have these things turned off NOW, so that, at least, 5.5
= > stands a chance? Thanks!
=
= What makes you think there is a measurable performance impact with
= them on?

Interesting... Are you implying, the debugging code makes no difference,
or are genuinly asking?

There are additional steps in the code, that are only done when
the define is on. Does not look like much in libthr, but c_r's
uthread/uthread_mutex.c seems quite affected, for example. And you know
it, of course...

= Regardless, it would first need to be in -current, not -stable.

I thought, the debugging features (WITNESS INVARIANTS) are always on in
-current, but are turned off in -stable for maximum performance. Is that
no longer true?

	-mi



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200505102343.42387>