Date: Sat, 15 Apr 2006 11:13:12 +0100 (BST) From: Gavin Atkinson <gavin.atkinson@ury.york.ac.uk> To: =?ISO-8859-1?Q?S=F8ren?= Schmidt <sos@freebsd.org> Cc: acpi@freebsd.org, Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org>, current@freebsd.org Subject: Re: CFR: ACPI Dock driver Message-ID: <20060415111208.Q34088@ury.york.ac.uk> In-Reply-To: <1145029263.912.4.camel@sos.deepcore.dk> References: <20060413.012156.56054177.iwasaki@jp.FreeBSD.org> <443F54DF.3080809@root.org> <20060414.180622.30189283.iwasaki@jp.FreeBSD.org> <20060414.233013.41626908.iwasaki@jp.FreeBSD.org> <1145029263.912.4.camel@sos.deepcore.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text,
while the remaining parts are likely unreadable without MIME-aware tools.
--0-767519609-1145095992=:34088
Content-Type: TEXT/PLAIN; charset=iso8859-1; format=flowed
Content-Transfer-Encoding: QUOTED-PRINTABLE
On Fri, 14 Apr 2006, [ISO-8859-1] S=F8ren Schmidt wrote:
> On Fre, 2006-04-14 at 23:30 +0900, Mitsuru IWASAKI wrote:
>> Hi, Soren.
>> I've found the problem with detached ATA channel suspending.
>> After detaching second channel, the system drops into infinity
>> loop at ata_suspend().
>> I'll commit the following patches with acpi_dock patches, so
>> please refine these if they have any problem.
>
> Uhm, would this simple patch help you ?
>
> --- ata-all.c 31 Mar 2006 08:09:04 -0000 1.271
> +++ ata-all.c 14 Apr 2006 15:39:20 -0000
> @@ -277,8 +277,8 @@
> if (!dev || !(ch =3D device_get_softc(dev)))
> return ENXIO;
>
> - /* wait for the channel to be IDLE before entering suspend mode */
> - while (1) {
> + /* wait for the channel to be IDLE or detached before suspending */
> + while (ch->r_irq) {
> mtx_lock(&ch->state_mtx);
> if (ch->state =3D=3D ATA_IDLE) {
> ch->state =3D ATA_ACTIVE;
>
> That I'll gladly commit for you instead...
Is there any chance this will also fix the panic myself and several others=
=20
have been seeing with suspend and CD-ROM drives?
http://unix.derkeiler.com/Mailing-Lists/FreeBSD/current/2005-08/0996.html
I'll take my laptop to top-of-tree CURRENT in the next day or so to try=20
it.
Gavin
--0-767519609-1145095992=:34088--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060415111208.Q34088>