Date: Fri, 17 Aug 2012 16:23:10 -0600 From: Ian Lepore <freebsd@damnhippie.dyndns.org> To: Kevin Oberman <kob6558@gmail.com> Cc: current@freebsd.org Subject: Re: CURRENT as gateway on not-so-fast hardware: where is a bottlneck? Message-ID: <1345242190.27688.162.camel@revolution.hippie.lan> In-Reply-To: <CAN6yY1vxsjxtuzo3m6QAvrr1x2yjS=ezB_3z1YzWiNbSnScJSQ@mail.gmail.com> References: <157941699.20120815004542@serebryakov.spb.ru> <CAJ-Vmon86-FPs4%2BXXkQXAow1jW465pMM2Sj7ZHi_0_E9VYSFSA@mail.gmail.com> <502AE8B5.9090106@FreeBSD.org> <502B775D.7000101@FreeBSD.org> <1849591745.20120815144006@serebryakov.spb.ru> <1345139226.27688.48.camel@revolution.hippie.lan> <174138639.20120817143840@serebryakov.spb.ru> <1345215393.27688.85.camel@revolution.hippie.lan> <CAJ-VmombFoUP1Saxd7y7Pzz2QrLX%2BgiQh9VgF5Pj68UOKDiXxg@mail.gmail.com> <1345223506.27688.116.camel@revolution.hippie.lan> <CAN6yY1vxsjxtuzo3m6QAvrr1x2yjS=ezB_3z1YzWiNbSnScJSQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 2012-08-17 at 14:29 -0700, Kevin Oberman wrote: > On Fri, Aug 17, 2012 at 10:11 AM, Ian Lepore > > No! Not bde! He'll notice that I violated style(9) by accidentally > > leaving an extra blank line between a comment block and the function > > definition. :) (There are probably more violations than that -- I did > > this when I was first trying to come to grips with the differences > > between style(9) and the almost-style(9) standards we use at work.) > > > > When I first proposed the changes, jhb remarked that they sounded good, > > but as far as I know, nobody reviewed the actual diff when I posted it. > > It looks like bde and phk were the primary maintainers back when this > > code was being more actively worked on. > > Why not bde? Everyone needs to learn what the term "bruceification" means. > > Believe me, there IS good reason for programming style and almost > everyone with a commit bit gets close. bde will provide a reminder of > any of those things you forgot were in style(9). This is something we > should appreciate, even if it does sting a bit. Did you miss the smiley I buried between two sentences there? Having worked on code written with no style guidelines, I totally understand the need for consistent style. While I find a couple of style(9)'s edicts to be massively annoying, all in all I'd rather work on code that has a consistent style I hate than on code with no consistency. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1345242190.27688.162.camel>