Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 9 Jan 2018 10:33:11 +0000 (UTC)
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r327721 - head/sys/ufs/ffs
Message-ID:  <201801091033.w09AXBdC034578@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kib
Date: Tue Jan  9 10:33:11 2018
New Revision: 327721
URL: https://svnweb.freebsd.org/changeset/base/327721

Log:
  Postpone the disassotiation of the background write buffer with devvp
  so that buf_complete() sees fully constructed buffer.
  
  This is a NOP right now, but will be needed by the forthcoming SU change.
  
  Reported and tested by:	pho
  Reviewed by:	mckusick
  Sponsored by:	The FreeBSD Foundation
  MFC after:	1 week

Modified:
  head/sys/ufs/ffs/ffs_vfsops.c

Modified: head/sys/ufs/ffs/ffs_vfsops.c
==============================================================================
--- head/sys/ufs/ffs/ffs_vfsops.c	Tue Jan  9 09:26:16 2018	(r327720)
+++ head/sys/ufs/ffs/ffs_vfsops.c	Tue Jan  9 10:33:11 2018	(r327721)
@@ -2045,7 +2045,6 @@ ffs_backgroundwritedone(struct buf *bp)
 	/*
 	 * Process dependencies then return any unfinished ones.
 	 */
-	pbrelvp(bp);
 	if (!LIST_EMPTY(&bp->b_dep) && (bp->b_ioflags & BIO_ERROR) == 0)
 		buf_complete(bp);
 #ifdef SOFTUPDATES
@@ -2058,6 +2057,7 @@ ffs_backgroundwritedone(struct buf *bp)
 	 */
 	bp->b_flags |= B_NOCACHE;
 	bp->b_flags &= ~B_CACHE;
+	pbrelvp(bp);
 
 	/*
 	 * Prevent brelse() from trying to keep and re-dirtying bp on



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201801091033.w09AXBdC034578>