Date: Wed, 22 Apr 2009 09:59:57 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Andriy Gapon <avg@icyb.net.ua> Cc: freebsd-geom@freebsd.org Subject: Re: glabel for ufs: size check is overzealous? Message-ID: <20090422075957.GB1663@garage.freebsd.pl> In-Reply-To: <49EDCA21.70908@icyb.net.ua> References: <49EDCA21.70908@icyb.net.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--0F1p//8PRICkK4MW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 21, 2009 at 04:29:05PM +0300, Andriy Gapon wrote: >=20 > glabel insists that for UFS2 the following must hold true: > pp->mediasize / fs->fs_fsize =3D=3D fs->fs_size >=20 > But in reality it doesn't have to be this way, there can be valid reasons= to make > filesystem smaller than available raw media size. >=20 > I understand that this is a good sanity check, but maybe there are other = ways to > extra-check that we see a proper superblock, without imposing the limitat= ion in > question. This check is there is case you have few GEOM providers that start at the same disk offset, but have different sizes. For example ad0s1, ad0s1a, mirror/foo, mirror/foo.journal all might start exactly at the same offset and glabel would have hard time to figure out on top of which to place glabel provider. Having file system smaller than provider size is perfectly valid, but this is about choosing lesser evil, that's all. It is just much more common to have file system using entire provider size. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --0F1p//8PRICkK4MW Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFJ7s59ForvXbEpPzQRAphCAJ9GApq7KwbhGArkf4xLMJjeSDlgwQCgsoE6 /jHijD5u4PadlvTwiDU1TJI= =ZsMN -----END PGP SIGNATURE----- --0F1p//8PRICkK4MW--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090422075957.GB1663>