Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 13 Jun 2025 12:30:39 GMT
From:      Christos Margiolis <christos@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: f482411563d6 - stable/14 - snd_hda: fix attaching to some AMD Radeon GPUs
Message-ID:  <202506131230.55DCUdt3039162@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/14 has been updated by christos:

URL: https://cgit.FreeBSD.org/src/commit/?id=f482411563d6c9ef1dfef3e59bb9e7fe3b6b4d91

commit f482411563d6c9ef1dfef3e59bb9e7fe3b6b4d91
Author:     Stefan Eßer <se@FreeBSD.org>
AuthorDate: 2025-06-12 07:47:57 +0000
Commit:     Christos Margiolis <christos@FreeBSD.org>
CommitDate: 2025-06-13 12:30:22 +0000

    snd_hda: fix attaching to some AMD Radeon GPUs
    
    HDMI audio did not work on my older Radeon GPU, the error message
    during attach was:
    
    hdac0: hdac_get_capabilities: Invalid corb size (0)
    
    This is fixed by calling hdac_reset() before the HDA device
    capabilities are retrieved. This solution was proposed by Andriy Gapon
    in 2010, but apparently did not solve the problem reported at the time.
    
    Approved by:    christos
    Differential Revision:  https://reviews.freebsd.org/D50737
    
    (cherry picked from commit dab9ef5448682c3c35e34d857b17ac1c23445321)
---
 sys/dev/sound/pci/hda/hdac.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sys/dev/sound/pci/hda/hdac.c b/sys/dev/sound/pci/hda/hdac.c
index be143ccd54c3..89742a0e4ebc 100644
--- a/sys/dev/sound/pci/hda/hdac.c
+++ b/sys/dev/sound/pci/hda/hdac.c
@@ -1278,6 +1278,7 @@ hdac_attach(device_t dev)
 		goto hdac_attach_fail;
 
 	/* Get Capabilities */
+	hdac_reset(sc, 1);
 	result = hdac_get_capabilities(sc);
 	if (result != 0)
 		goto hdac_attach_fail;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202506131230.55DCUdt3039162>